Skip to content

Update POS cart api docs to reflect discount per unit allocation#4231

Merged
janezhu918 merged 1 commit into2026-04-rcfrom
janezhu/update_pos_cart_api_docs_to_reflect_discount_per_unit_allocation
Mar 27, 2026
Merged

Update POS cart api docs to reflect discount per unit allocation#4231
janezhu918 merged 1 commit into2026-04-rcfrom
janezhu/update_pos_cart_api_docs_to_reflect_discount_per_unit_allocation

Conversation

@janezhu918
Copy link
Copy Markdown
Contributor

@janezhu918 janezhu918 commented Mar 26, 2026

Background

Resolves https://github.com/shop/issues-retail/issues/26385

Update documentation for discount allocation change from ACROSS to EACH starting in API version 2026-04.

Solution

Update docs and provide example

🎩

  • Ran yarn docs:point-of-sale 2026-04-rc in this repo.
  • Ran this to copy over the generated files (temporary command while the migration is finalized):
cp -r /Users/janezhu/src/github.com/Shopify/ui-extensions/packages/ui-extensions/docs/surfaces/point-of-sale/generated/pos_ui_extensions/2026-04-rc \
    /Users/janezhu/world/trees/root/src/areas/platforms/shopify-dev/db/data/docs/templated_apis/pos_ui_extensions/

Screenshot 2026-03-26 at 3.01.12 PM.png

Screenshot 2026-03-26 at 3.01.18 PM.png

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@github-actions
Copy link
Copy Markdown
Contributor

🚨🚨🚨 Docs migration in progress 🚨🚨🚨

We are actively migrating UI extension reference docs to MDX in the areas/platforms/shopify-dev zone of the monorepo. This impacts docs for the following surfaces:

During this migration, please be aware of the following:

.doc.ts files are being deprecated. Changes to .doc.ts files in this repo will not be reflected in the new MDX-based docs. If you need to update docs for a reference that has already been migrated, make your changes directly in the areas/platforms/shopify-dev zone of the monorepo instead.

Doc comments in .ts source files (the comment blocks above types and functions) are also affected. Generating docs from these comments currently requires a newer version of the @shopify/generate-docs library that isn't yet available. Updates to doc comments may not produce the expected output until the migration is complete.

Examples that previously lived in this repo are being moved to the areas/platforms/shopify-dev zone of the monorepo and should be authored there going forward.

What should I do?

  • If your PR includes changes to .doc.ts files, doc comments, or examples, please reach out to us in #devtools-proj-templated-refs so we can help ensure your updates are captured correctly.
  • If your PR is limited to source code changes (non-docs), you can ignore this notice.

Thanks for your patience while we complete the migration! 🙏

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@janezhu918 janezhu918 force-pushed the janezhu/update_pos_cart_api_docs_to_reflect_discount_per_unit_allocation branch from 4b3419a to 83f2939 Compare March 26, 2026 18:38
@janezhu918 janezhu918 force-pushed the janezhu/update_pos_cart_api_docs_to_reflect_discount_per_unit_allocation branch from 83f2939 to 560043d Compare March 26, 2026 18:44
@janezhu918 janezhu918 self-assigned this Mar 26, 2026
@janezhu918 janezhu918 marked this pull request as ready for review March 26, 2026 19:24
Copy link
Copy Markdown
Contributor Author

janezhu918 commented Mar 27, 2026

Merge activity

  • Mar 27, 3:01 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 3:01 PM UTC: @janezhu918 merged this pull request with Graphite.

@janezhu918 janezhu918 merged commit c9c4a93 into 2026-04-rc Mar 27, 2026
6 checks passed
janezhu918 added a commit that referenced this pull request Mar 30, 2026
…ion" (#4240)

Part of shop/issues-retail#26513

### Background

Reverting #4231 PR to defer this change to 2026-07. Will update docs then. No update needed on the `shopify-dev` dev side since the doc update PR was never merged (shop/world#553810).

### Solution

n/a

### 🎩

- Ran `yarn docs:point-of-sale 2026-04` in this repo.
- Provide absolute path for the `shopify-dev` repo location (should be something like `/Users/janezhu/world/trees/root/src/areas/platforms/shopify-dev/`)

- In `shopify-dev` repo (now in the monorepo), run `dev server`
- Go to your local https://shopify-dev.shop.dev/docs/api/pos-ui-extensions/2026-04-rc/target-apis/contextual-apis/cart-api to see the reverted docs:

![Screenshot 2026-03-30 at 12.00.22 PM.png](https://app.graphite.com/user-attachments/assets/6025f2bd-a199-47d5-b8ae-be00bae78b55.png)

![Screenshot 2026-03-30 at 12.00.59 PM.png](https://app.graphite.com/user-attachments/assets/b3cd2c55-fc0b-4ed4-8fc9-d8d5a504a918.png)



### Checklist

- [x] I have 🎩'd these changes
- [x] I have updated relevant documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants