Skip to content

Add types for admin.app.intent.render#4251

Merged
JoviDeCroock merged 4 commits into2026-04-rcfrom
add-support-for-admin-app-intent-render
Apr 9, 2026
Merged

Add types for admin.app.intent.render#4251
JoviDeCroock merged 4 commits into2026-04-rcfrom
add-support-for-admin-app-intent-render

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Contributor

@JoviDeCroock JoviDeCroock commented Apr 2, 2026

Background

This adds the types for supporting admin.app.intent.render

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚨🚨🚨 Docs migration in progress 🚨🚨🚨

We are actively migrating UI extension reference docs to MDX in the areas/platforms/shopify-dev zone of the monorepo. This impacts docs for the following surfaces:

During this migration, please be aware of the following:

.doc.ts files are being deprecated. Changes to .doc.ts files in this repo will not be reflected in the new MDX-based docs. If you need to update docs for a reference that has already been migrated, make your changes directly in the areas/platforms/shopify-dev zone of the monorepo instead.

Doc comments in .ts source files (the comment blocks above types and functions) are also affected. Generating docs from these comments currently requires a newer version of the @shopify/generate-docs library that isn't yet available. Updates to doc comments may not produce the expected output until the migration is complete.

Examples that previously lived in this repo are being moved to the areas/platforms/shopify-dev zone of the monorepo and should be authored there going forward.

What should I do?

  • If your PR includes changes to .doc.ts files, doc comments, or examples, please reach out to us in #devtools-proj-templated-refs so we can help ensure your updates are captured correctly.
  • If your PR is limited to source code changes (non-docs), you can ignore this notice.

Thanks for your patience while we complete the migration! 🙏

@kbav
Copy link
Copy Markdown
Contributor

kbav commented Apr 2, 2026

/snapit

@shopify-github-actions-access
Copy link
Copy Markdown
Contributor

shopify-github-actions-access bot commented Apr 2, 2026

🫰✨ Thanks @kbav! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/ui-extensions": "0.0.0-snapshot-20260402155710",
"@shopify/ui-extensions-tester": "0.0.0-snapshot-20260402155710"

@JoviDeCroock JoviDeCroock force-pushed the add-support-for-admin-app-intent-render branch 2 times, most recently from 65d8649 to cfc590b Compare April 9, 2026 07:31
JoviDeCroock
JoviDeCroock commented Apr 9, 2026
View reviewed changes
vividviolet
vividviolet reviewed Apr 9, 2026
View reviewed changes
@JoviDeCroock JoviDeCroock force-pushed the add-support-for-admin-app-intent-render branch 3 times, most recently from a4e16c5 to 9b24342 Compare April 9, 2026 15:30
vividviolet
vividviolet approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vividviolet vividviolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just need to add a changeset

@JoviDeCroock JoviDeCroock force-pushed the add-support-for-admin-app-intent-render branch from 9b24342 to 5226e02 Compare April 9, 2026 15:35
@JoviDeCroock
Copy link
Copy Markdown
Contributor Author

JoviDeCroock commented Apr 9, 2026

@vividviolet there is one in https://github.com/Shopify/ui-extensions/blob/5226e0245c64681ec4e60c911ffc89ec9c428d71/.changeset/add-admin-app-intent-render-target.md

@JoviDeCroock JoviDeCroock force-pushed the add-support-for-admin-app-intent-render branch from 5226e02 to 5ba5316 Compare April 9, 2026 15:37
@vividviolet Graphite App
Copy link
Copy Markdown
Member

vividviolet commented Apr 9, 2026

Perfect

@JoviDeCroock JoviDeCroock force-pushed the add-support-for-admin-app-intent-render branch from 5ba5316 to 96efc07 Compare April 9, 2026 15:42
JoviDeCroock and others added 4 commits April 9, 2026 17:45
@JoviDeCroock
Add types for admin.app.intent.render
56e2bf9
@JoviDeCroock @claude
Fix missing data property in createAppIntentRenderMock
6ae22b7 
IntentRenderApi requires a `data` property with an `intent` field.
The mock was missing it, causing type-check and test CI failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@JoviDeCroock @claude
Fix test to expect data property on intent render mock
6704459 
The test was asserting data should NOT exist, but IntentRenderApi
requires it. Updated to verify the mock data is correct instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@JoviDeCroock
Fork type in the app intents extensions
26db774
@JoviDeCroock JoviDeCroock force-pushed the add-support-for-admin-app-intent-render branch from 96efc07 to 26db774 Compare April 9, 2026 15:45
@JoviDeCroock JoviDeCroock merged commit a5c2bbf into 2026-04-rc Apr 9, 2026
6 checks passed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Apr 9, 2026
Open
@kbav kbav mentioned this pull request Apr 10, 2026
Closed
2 tasks
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Apr 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vividviolet vividviolet vividviolet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoviDeCroock @kbav @vividviolet