Skip to content

Conversation

@martelogan
Copy link
Member

@martelogan martelogan commented Jun 10, 2024

I believe this snippet was just meant to alias .to_a to the raw bytes array, but was previously dereferencing a symbol - which did not fail statically but would fail at runtime or in generating new .rbi files for the gem when integrating to caller code:

image

@colinbendell colinbendell self-requested a review June 11, 2024 01:41
@martelogan martelogan force-pushed the fix-erroneous-delegation branch from c1dda26 to 752170a Compare June 11, 2024 17:58
@martelogan martelogan force-pushed the fix-erroneous-delegation branch from 752170a to e328a9a Compare June 11, 2024 18:09
@martelogan martelogan merged commit af16cc6 into master Jun 12, 2024
@martelogan martelogan self-assigned this Aug 16, 2024
@martelogan martelogan added the #gsd:40924 Checkout Flash Cookies Migration: https://vault.shopify.io/gsd/projects/40924 label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:40924 Checkout Flash Cookies Migration: https://vault.shopify.io/gsd/projects/40924

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants