This repository was archived by the owner on May 30, 2024. It is now read-only.
Make sure we stop the current client before restarting#369
Merged
Conversation
bitwise-aiden
approved these changes
Feb 2, 2023
st0012
approved these changes
Feb 2, 2023
This was referenced Feb 9, 2023
jayanth-kumar-morem
pushed a commit
to jayanth-kumar-morem/vscode-ruby-lsp
that referenced
this pull request
Apr 26, 2023
…p-minitest-0.24.0 Bump rubocop-minitest from 0.23.2 to 0.24.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Shopify/ruby-lsp#1505
Given this scenario:
Gemfile,Gemfile.lockor any other watched filesbundle installon the dialogueThe reason this happens is because
restartthis.client. That means that invokingstopdidn't create a stop promise, because the client wasn't set yetThe fix is to properly await the promises and set
this.clientearly, so that we can properly return astoppromise when restarting a client that is hanging waiting for a dialogue confirmation.