Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Add experimental features configuration to enable all features at once#383

Merged
vinistock merged 2 commits intomainfrom
vs/add_experimenta_features_option
Feb 13, 2023
Merged

Add experimental features configuration to enable all features at once#383
vinistock merged 2 commits intomainfrom
vs/add_experimenta_features_option

Conversation

@vinistock
Copy link
Copy Markdown
Member

By default, our new features should all be enabled: false in our configurations so that we can test them out and catch bugs before enabling them for everybody.

However, there are always developers who are willing to beta test features and report issues and we should make it easy for them to do so.

This PR adds a configuration for enableExperimentalFeatures, which enables all features regardless of whether they are still under development or not.

@vinistock vinistock requested a review from a team as a code owner February 8, 2023 21:55
@vinistock vinistock self-assigned this Feb 8, 2023
@vinistock vinistock added the enhancement New feature or request label Feb 8, 2023
Copy link
Copy Markdown
Contributor

@adisonlampert adisonlampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we might want to allow people to toggle on and off as a language status item? 👀

This is useful for users that want to help us beta test under
development features that are not ready to be enabled for all developers
yet
@vinistock vinistock force-pushed the vs/add_experimenta_features_option branch from b25230e to 1e979b8 Compare February 13, 2023 15:21
@vinistock vinistock force-pushed the vs/add_experimenta_features_option branch from 1e979b8 to 705e30c Compare February 13, 2023 15:25
@vinistock
Copy link
Copy Markdown
Member Author

@adisonlampert that's a good call. I added a language status item for enabling experimental features.

I also fixed an issue with disabling and enabling YJIT. When we invoke update, the default is to change workspace settings, which changes the .vscode/settings.json file, but we actually want global user settings. The fix is just to pass the last two arguments to update as true and true.

@vinistock vinistock merged commit 08c2398 into main Feb 13, 2023
@vinistock vinistock deleted the vs/add_experimenta_features_option branch February 13, 2023 18:44
jayanth-kumar-morem pushed a commit to jayanth-kumar-morem/vscode-ruby-lsp that referenced this pull request Apr 26, 2023
…tion-test-runner

Illustrate which tests `ExpectationsTestRunner` is running
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants