This repository was archived by the owner on May 30, 2024. It is now read-only.
Allow restart command to fail gracefully#420
Merged
Conversation
KaanOzkan
approved these changes
Mar 1, 2023
andyw8
reviewed
Mar 1, 2023
vinistock
force-pushed
the
vs/prevent_commands_from_failing
branch
from
836f84d to
49eb39d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Shopify/ruby-lsp#1483
If we let commands raise, VS Code won't let you use them again without reloading the window completely. That's not super helpful and we should rather catch the error and log it in the output channel.
Also, as accurately pointed out by Ufuk #385 (comment), declaring a function as
asyncand then only doingawaitinside of them has no difference when compared to just returning the function straight away. The behaviour will depend on whether the consumer of the function is awaiting or not (in this case VS Code). So I switched to a less verbose implementation.