Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Show errors when working on ruby-lsp and ruby-lsp-rails#680

Merged
vinistock merged 2 commits intomainfrom
vs/show_errors_in_ruby_lsp
Jul 6, 2023
Merged

Show errors when working on ruby-lsp and ruby-lsp-rails#680
vinistock merged 2 commits intomainfrom
vs/show_errors_in_ruby_lsp

Conversation

@vinistock
Copy link
Copy Markdown
Member

Motivation

Closes Shopify/ruby-lsp#1585

When working on ruby-lsp and ruby-lsp-rails, it's better to have errors surfaced straight away than sending to telemetry, so that we can see it and address it soon. This will be particularly useful for large migrations, like transitioning to YARP.

Implementation

Started showing a dialogue if the error telemetry occurred inside of ruby-lsp or ruby-lsp-rails.

@vinistock vinistock added the enhancement New feature or request label Jul 5, 2023
@vinistock vinistock added this to the 2023-Q2 milestone Jul 5, 2023
@vinistock vinistock self-assigned this Jul 5, 2023
@vinistock vinistock requested a review from a team as a code owner July 5, 2023 21:15
@vinistock vinistock requested review from KaanOzkan and egiurleo July 5, 2023 21:15
Copy link
Copy Markdown
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea and I really appreciate how this will tighten our feedback loops 💪🏻

Is there any value in sending these errors to telemetry in addition to showing the error in VSCode? I'm assuming most devs are not working on ruby-lsp or ruby-lsp-rails, so the errors from these repos are likely a drop in the bucket for us, but I imagine there's still value from capturing them in our telemetry?

Comment thread src/client.ts Outdated
Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
@vinistock
Copy link
Copy Markdown
Member Author

@egiurleo one of the slightly annoying things about sending telemetry is that if someone is actively changing the Ruby LSP and makes a mistake, we get those on telemetry - even though they don't actually mean anything because they were triggered during development.

We in fact already filter them out in our telemetry queries, so we're not seeing it at the moment.

@vinistock vinistock merged commit 23517cc into main Jul 6, 2023
@vinistock vinistock deleted the vs/show_errors_in_ruby_lsp branch July 6, 2023 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surface errors when developing ruby-lsp or ruby-lsp-rails

3 participants