Show errors when working on ruby-lsp and ruby-lsp-rails#680
Conversation
egiurleo
left a comment
There was a problem hiding this comment.
This is a good idea and I really appreciate how this will tighten our feedback loops 💪🏻
Is there any value in sending these errors to telemetry in addition to showing the error in VSCode? I'm assuming most devs are not working on ruby-lsp or ruby-lsp-rails, so the errors from these repos are likely a drop in the bucket for us, but I imagine there's still value from capturing them in our telemetry?
Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
|
@egiurleo one of the slightly annoying things about sending telemetry is that if someone is actively changing the Ruby LSP and makes a mistake, we get those on telemetry - even though they don't actually mean anything because they were triggered during development. We in fact already filter them out in our telemetry queries, so we're not seeing it at the moment. |
Motivation
Closes Shopify/ruby-lsp#1585
When working on
ruby-lspandruby-lsp-rails, it's better to have errors surfaced straight away than sending to telemetry, so that we can see it and address it soon. This will be particularly useful for large migrations, like transitioning to YARP.Implementation
Started showing a dialogue if the error telemetry occurred inside of
ruby-lsporruby-lsp-rails.