This repository was archived by the owner on May 30, 2024. It is now read-only.
Show server version in status language item#771
Merged
Conversation
KaanOzkan
approved these changes
Aug 30, 2023
bitwise-aiden
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since many people don't have the Ruby LSP in their Gemfiles, it's hard to tell which version of the server they are running. We already have this information, so it's very easy to expose it.
Implementation
Started showing the server version in the server status language item. We only show it if the server is running because the version is not available before then.
Automated Tests
Adapted the existing tests.