This repository was archived by the owner on May 30, 2024. It is now read-only.
Conversation
vinistock
force-pushed
the
vs/fix_debugger_usage_with_custom_gemfile
branch
from
2c7d7f7 to
9f6d468
Compare
vinistock
force-pushed
the
vs/make_tests_pass_locally
branch
from
2ccafce to
f17c1f9
Compare
vinistock
force-pushed
the
vs/fix_debugger_usage_with_custom_gemfile
branch
from
9f6d468 to
004470f
Compare
KaanOzkan
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes Shopify/ruby-lsp#1749
We need to point
BUNDLE_GEMFILEto our custom bundle if it exists when we are launching the debugger. Otherwise, if the debug gem is not a part of the main bundle, we won't be able to launch it.Implementation
Started checking if the custom bundle is there and if it is we inject
BUNDLE_GEMFILEinto the environment.Automated Tests
Added a test to verify that the right path is being injected.
Manual Tests