This repository was archived by the owner on May 30, 2024. It is now read-only.
Merged
Conversation
andyw8
approved these changes
Oct 12, 2023
Contributor
andyw8
left a comment
andyw8
left a comment
There was a problem hiding this comment.
I suppose the other option would be to massage the data on the server side to remove the outliers, but that could be awkward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The initial requests are not representative of the performance of the LSP because they are initially blocked by indexing. Additionally, other things impact the measurement like autoloads or Sorbet unwrapping signatures.
Implementation
Started returning early if the request id is below 50.