This repository was archived by the owner on May 30, 2024. It is now read-only.
Merged
Conversation
1 task
paracycle
reviewed
Oct 19, 2023
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
paracycle
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes Shopify/ruby-lsp#1724
When someone specifies a custom bundle gemfile in order to use a Ruby version different than their project, we need to read the
.ruby-versionfile from the directory where the custom bundle exists.Additionally, we need to use the correct directory when fetching Ruby information or else we end up activating the correct Ruby version, but displaying the wrong one in the status item.
Implementation
Put the
cwdin a property and started using it everywhere we need it.