This repository was archived by the owner on May 30, 2024. It is now read-only.
Alert shadowenv users about missing Ruby#873
Merged
Conversation
KaanOzkan
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the files under the
.shadowenv.ddirectory are configured with a Ruby version that is not installed in the machine, shadowenv does not throw any errors. Instead, it returns the "activated" environment, pointing to a bunch of paths that don't actually exist.That can be very confusing for users, so we should let them know that something is not right.
Implementation
Started checking if the
RUBY_ROOTconfigured exists. If that directory is missing, then either the Ruby version isn't installed or it was installed elsewhere. In both cases, the solution is to re-generate the files under.shadowenv.dwith the right paths.