Skip to content

Conversation

@DominiqueFlaaa
Copy link
Contributor

@DominiqueFlaaa DominiqueFlaaa commented Oct 10, 2025

What are you trying to accomplish?

Patch a few Spanish provinces in the PT locale, removing the superscript 2.

This document contains details on the superscript markers, why they are sometimes necessary to distinguish between subdivisions that have identical translated names, and shows a few long term options to fix the problem: cldr-superscript-markers.md
In the case of the Spanish provinces in PT, there are no duplicate translations.

There is no quick fix for all occurrences, so for now I'm addressing this one case on our radar.

What approach did you choose and why?

Added to the existing patches list, re-ran the end-to-end CLDR import.
Verified the changes are present in the pt/subdivisions.yml ✔️

claude init to add a CLAUDE.md

The impact of these changes

This should fix an issue where Spanish provinces in PT are shown with superscript 2.

Checklist

  • I have added a CHANGELOG entry for this change (or determined that it isn't needed)

@DominiqueFlaaa DominiqueFlaaa changed the title patch ES provinces to remove superscript markers cut v1.18.1, patch pt subdivisions to remove superscript markers Oct 10, 2025
@DominiqueFlaaa DominiqueFlaaa marked this pull request as ready for review October 10, 2025 19:56
@DominiqueFlaaa DominiqueFlaaa force-pushed the df.patch-es-provinces-add-claude-md branch from 833ba48 to 0b30c91 Compare October 10, 2025 20:28
@DominiqueFlaaa DominiqueFlaaa requested a review from a team October 14, 2025 13:57
@gabypancu
Copy link
Contributor

In the case of the Spanish provinces in PT, there are no duplicate translations.

I see duplicates for most of the affected provinces in the pt file 👀 am I interpreting incorrectly? For example:

image

@DominiqueFlaaa
Copy link
Contributor Author

Yes, you are right to spot the duplicates! I will revisit the approach

@DominiqueFlaaa DominiqueFlaaa marked this pull request as draft October 14, 2025 20:49
@DominiqueFlaaa
Copy link
Contributor Author

DominiqueFlaaa commented Oct 24, 2025

The unicode data for spain shows the keys for these "duplicate names" are used for different subdivision levels:

Screenshot 2025-10-24 at 1 04 13 PM

Categorizing each duplicate name:

name code subdivision level
Navarra esnc 1
Navarra esna 2
Cantábria escb 1
Cantábria ess 2
Baleares esib 1
Baleares espm 2
La Rioja esri 1
La Rioja eslo 2

This PR updates the second subdivision level for each, except La Rioja.

When showing the zones of Spain, our systems care about this second subdivision level.


I will remove the patch on La Rioja, and focus this change to updating the second subdivision levels of Spain in Portuguese.

@DominiqueFlaaa DominiqueFlaaa force-pushed the df.patch-es-provinces-add-claude-md branch from 1878e99 to b2b699d Compare October 24, 2025 17:22
@DominiqueFlaaa DominiqueFlaaa marked this pull request as ready for review October 24, 2025 17:23
@DominiqueFlaaa DominiqueFlaaa force-pushed the df.patch-es-provinces-add-claude-md branch from 97a443d to 1202e6d Compare October 24, 2025 17:32
espv: Comunidade autónoma do País Basco
esri: La Rioja²
ess: Cantábria²
ess: Cantábria
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not change esri: La Rioja² as this key is for the regional subvidivision (level-1), not the provincial subdivisions (level 2) which are the focus of this patch.

@DominiqueFlaaa DominiqueFlaaa changed the title cut v1.18.1, patch pt subdivisions to remove superscript markers cut v1.20.1, patch pt-language provinces to remove superscript markers Oct 24, 2025
@DominiqueFlaaa DominiqueFlaaa force-pushed the df.patch-es-provinces-add-claude-md branch from 1202e6d to 4c36ba3 Compare November 3, 2025 14:52
@DominiqueFlaaa DominiqueFlaaa merged commit 70fdb31 into main Nov 3, 2025
6 checks passed
@DominiqueFlaaa DominiqueFlaaa deleted the df.patch-es-provinces-add-claude-md branch November 3, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants