-
Notifications
You must be signed in to change notification settings - Fork 10
cut v1.20.1, patch pt-language provinces to remove superscript markers #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
833ba48 to
0b30c91
Compare
|
Yes, you are right to spot the duplicates! I will revisit the approach |
|
The unicode data for spain shows the keys for these "duplicate names" are used for different subdivision levels: Categorizing each duplicate name:
This PR updates the second subdivision level for each, except La Rioja. When showing the zones of Spain, our systems care about this second subdivision level. I will remove the patch on La Rioja, and focus this change to updating the second subdivision levels of Spain in Portuguese. |
1878e99 to
b2b699d
Compare
97a443d to
1202e6d
Compare
| espv: Comunidade autónoma do País Basco | ||
| esri: La Rioja² | ||
| ess: Cantábria² | ||
| ess: Cantábria |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not change esri: La Rioja² as this key is for the regional subvidivision (level-1), not the provincial subdivisions (level 2) which are the focus of this patch.
1202e6d to
4c36ba3
Compare
What are you trying to accomplish?
Patch a few Spanish provinces in the PT locale, removing the superscript 2.
This document contains details on the superscript markers, why they are sometimes necessary to distinguish between subdivisions that have identical translated names, and shows a few long term options to fix the problem: cldr-superscript-markers.md
In the case of the Spanish provinces in PT, there are no duplicate translations.
There is no quick fix for all occurrences, so for now I'm addressing this one case on our radar.
What approach did you choose and why?
Added to the existing patches list, re-ran the end-to-end CLDR import.
Verified the changes are present in the pt/subdivisions.yml ✔️
claude initto add a CLAUDE.mdThe impact of these changes
This should fix an issue where Spanish provinces in PT are shown with superscript 2.
Checklist