Skip to content

Add address1 format strings for NL; prepare v1.21.3 patch release#427

Merged
rochlefebvre merged 2 commits intomainfrom
nl-address1-format-strings
Jan 26, 2026
Merged

Add address1 format strings for NL; prepare v1.21.3 patch release#427
rochlefebvre merged 2 commits intomainfrom
nl-address1-format-strings

Conversation

@rochlefebvre
Copy link
Contributor

What are you trying to accomplish?

Define canonical address1 formats for Netherlands addresses having a building number only, or both a building and a unit number. Note that no Worldwide methods leverage these patterns.

I'm also preparing a patch release with these changes.

Checklist

  • I have added a CHANGELOG entry for this change (or determined that it isn't needed)

Comment on lines +29 to +30
address1: "{street} {building_num}"
address1_with_unit: "{street} {building_num}-{unit}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using these UPU formatting guidelines as a reference, since the post.nl website does not seem to specify how to write the unit.

Our own logs show that most NL subpremise addresses use a hyphen between the house and unit numbers.

@rochlefebvre rochlefebvre marked this pull request as ready for review January 25, 2026 20:45
@rochlefebvre rochlefebvre requested a review from a team January 25, 2026 20:45
Copy link
Contributor

@o-benz o-benz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

little note: don't we usually make the fix and cut the new version in two separate PRs 🤔 ?

PS: (I'm bumping worldwide and country_db in these PRs: https://github.com/Shopify/atlas/pull/6803, https://github.com/shop/world/pull/375097, if you'd like, I can hold off until your new versions of worldwide and country are cut and tagged so I can just bump from 1.21.0 to 1.21.3 directly)

@rochlefebvre
Copy link
Contributor Author

LGTM!

little note: don't we usually make the fix and cut the new version in two separate PRs 🤔 ?

Yes, we usually do separate the code changes from the version bumps. In cases like mine, where we need to release the code change imminently, then we may bundle them together.

PS: (I'm bumping worldwide and country_db in these PRs: Shopify/atlas#6803, shop/world#375097, if you'd like, I can hold off until your new versions of worldwide and country are cut and tagged so I can just bump from 1.21.0 to 1.21.3 directly)

You may go ahead with your PRs and ignore mine. This PR is actually transparent to country_db (no changes or bumping needed for that library). Worst case, I bump worldwide before you do and your PR needs to play catch up.

@rochlefebvre rochlefebvre merged commit 27ae4f2 into main Jan 26, 2026
6 checks passed
@rochlefebvre rochlefebvre deleted the nl-address1-format-strings branch January 26, 2026 13:13
@rochlefebvre rochlefebvre mentioned this pull request Jan 26, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants