Add address1 format strings for NL; prepare v1.21.3 patch release#427
Add address1 format strings for NL; prepare v1.21.3 patch release#427rochlefebvre merged 2 commits intomainfrom
Conversation
| address1: "{street} {building_num}" | ||
| address1_with_unit: "{street} {building_num}-{unit}" |
There was a problem hiding this comment.
Using these UPU formatting guidelines as a reference, since the post.nl website does not seem to specify how to write the unit.
Our own logs show that most NL subpremise addresses use a hyphen between the house and unit numbers.
o-benz
left a comment
There was a problem hiding this comment.
LGTM!
little note: don't we usually make the fix and cut the new version in two separate PRs 🤔 ?
PS: (I'm bumping worldwide and country_db in these PRs: https://github.com/Shopify/atlas/pull/6803, https://github.com/shop/world/pull/375097, if you'd like, I can hold off until your new versions of worldwide and country are cut and tagged so I can just bump from 1.21.0 to 1.21.3 directly)
Yes, we usually do separate the code changes from the version bumps. In cases like mine, where we need to release the code change imminently, then we may bundle them together.
You may go ahead with your PRs and ignore mine. This PR is actually transparent to country_db (no changes or bumping needed for that library). Worst case, I bump worldwide before you do and your PR needs to play catch up. |
What are you trying to accomplish?
Define canonical address1 formats for Netherlands addresses having a building number only, or both a building and a unit number. Note that no Worldwide methods leverage these patterns.
I'm also preparing a patch release with these changes.
Checklist