Update IT Sardinian zones, release v1.24.0#451
Merged
DominiqueFlaaa merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
DominiqueFlaaa
force-pushed
the
df.update-it-provinces
branch
2 times, most recently
from
c0f469d to
13503e5
Compare
DominiqueFlaaa
force-pushed
the
df.update-it-provinces
branch
from
13503e5 to
01ce909
Compare
rochlefebvre
approved these changes
Apr 13, 2026
4 tasks
DominiqueFlaaa
added a commit
that referenced
this pull request
Apr 27, 2026
PR #451 updated `data/regions/IT.yml` to reflect Italy's 2025 restoration of Sardinian provinces, but left `data/cldr/locales/<locale>/subdivisions.yml` carrying the old names. Consumers that resolve province labels through CLDR (e.g. atlas's `country_formatter.rb` via `ShopifyI18n::Zone#name` -> `I18n.t("subdivisions.itXX")`) silently overrode the corrected `country_db` names with stale CLDR translations. This commit patches CLDR data so the new names propagate for the source locales (en, it): IT-OT: Olbia-Tempio -> Gallura Nord-Est Sardegna IT-CI: Carbonia-Iglesias -> Sulcis Iglesiente Other locales are handled by Shopify's translation platform automations. - rake/cldr/patch.rb: extended the static :it patch and added a static :en patch (so future cldr:data:import runs re-apply this fix). - data/cldr/locales/{en,it}/subdivisions.yml: regenerated. - Bumped to v1.24.2 + CHANGELOG entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DominiqueFlaaa
added a commit
that referenced
this pull request
Apr 28, 2026
PR #451 updated `data/regions/IT.yml` to reflect Italy's June 2025 restoration of two Sardinian provinces, but left `data/cldr/locales/<locale>/subdivisions.yml` carrying the old names. Consumers that resolve province labels through CLDR (e.g. atlas's `country_formatter.rb` via `ShopifyI18n::Zone#name` -> `I18n.t("subdivisions.itXX")`) silently overrode the corrected country_db names with stale CLDR translations, so admin/buyer surfaces in atlas continued to display "Olbia-Tempio" and "Carbonia-Iglesias". This commit patches CLDR data so the new names propagate: IT-OT: Olbia-Tempio -> Gallura Nord-Est Sardegna IT-CI: Carbonia-Iglesias -> Sulcis Iglesiente - :en (source) and :it (locale) patched -- corrects the language used by Italian-speaking merchants and the English source string. - :de patched -- largest non-en/it consumer of IT addresses; prefix-preserving form ("Provinz Gallura Nord-Est Sardegna" / "Provinz Sulcis Iglesiente"). - All other locales remain on stale upstream CLDR. Shopify's translation-platform[bot] only fans out files under data/regions/, data/other/hand_translated/, and data/other/timezones/ -- it does not touch data/cldr/, so it cannot propagate this fix. Tracking via TODO in patch.rb pending an upstream Unicode CLDR update. - rake/cldr/patch.rb: static :it/:en/:de patches so future cldr:data:import runs re-apply the fix. - data/cldr/locales/{en,it,de}/subdivisions.yml: updated. - Bumped to v1.24.2 + CHANGELOG entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DominiqueFlaaa
added a commit
that referenced
this pull request
Apr 28, 2026
PR #451 updated `data/regions/IT.yml` to reflect Italy's June 2025 restoration of two Sardinian provinces, but left `data/cldr/locales/<locale>/subdivisions.yml` carrying the old names. Consumers that resolve province labels through CLDR (e.g. atlas's `country_formatter.rb` via `ShopifyI18n::Zone#name` -> `I18n.t("subdivisions.itXX")`) silently overrode the corrected country_db names with stale CLDR translations, so admin/buyer surfaces in atlas continued to display "Olbia-Tempio" and "Carbonia-Iglesias". This commit patches CLDR data so the new names propagate: IT-OT: Olbia-Tempio -> Gallura Nord-Est Sardegna IT-CI: Carbonia-Iglesias -> Sulcis Iglesiente - :en (source) and :it (locale) patched -- corrects the language used by Italian-speaking merchants and the English source string. - :de patched -- largest non-en/it consumer of IT addresses; prefix-preserving form ("Provinz Gallura Nord-Est Sardegna" / "Provinz Sulcis Iglesiente"). - All other locales remain on stale upstream CLDR. Shopify's translation-platform[bot] only fans out files under data/regions/, data/other/hand_translated/, and data/other/timezones/ -- it does not touch data/cldr/, so it cannot propagate this fix. Tracking via TODO in patch.rb pending an upstream Unicode CLDR update. - rake/cldr/patch.rb: static :it/:en/:de patches so future cldr:data:import runs re-apply the fix. - data/cldr/locales/{en,it,de}/subdivisions.yml: updated. - Bumped to v1.24.2 + CHANGELOG entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Italy's Sardinian provinces to reflect 2025 administrative restoration
Summary
Italy restored several Sardinian provinces in June 2025 that had been consolidated in 2019. This PR updates
IT.ymlto reflect the current administrative boundaries, verified against tuttitalia.it and poste.it postal code data.Problem
Three Sardinian province zones were out of date:
deprecated: truewith nozip_prefixes. All Gallura postcodes (07020–07029, 07038, 07051, 07052) resolved to Sassari (SS) instead.09064). Its core postcodes (08040–08049) resolved to Nuoro (NU) because NU held a competing'0804'prefix.When assigning zone from zip, this would result in incorrect province assignments for addresses in these territories.
Changes
data/regions/IT.ymlOT — Un-deprecate and restore as Gallura Nord-Est Sardegna
deprecated: truezip_prefixes(07020–07029, 07030, 07038, 07051, 07052)name_alternatesOG — Expand with correct Ogliastra postcodes
zip_prefixes'0804'prefix (no current Nuoro municipality uses an0804xpostcode)SS — Disambiguate from OT
'07'prefix with 11 specific prefixes (0701,07031–07037,07039,0704,07100) to avoid overlap with OT's070xxprefixes, which is required by thezip_prefixes_are_unambiguousconsistency testCI — Rename to Sulcis Iglesiente
name_alternatesCrossings
07030as OT+SS crossing (shared between 3 OT and 11 SS municipalities)Comments
test/worldwide/region_data_consistency_test.rbValidation
zone(zip:)zips_crossing_provincesentries satisfy the first-match and neighbour constraintsChecklist