Allow calling variadic cfuncs with many args#201
Merged
maximecb merged 4 commits intoShopify:mainfrom Sep 8, 2021
Merged
Conversation
We have a check to ensure we don't have to push args on the stack to call a cfunc with many args. However we never need to use the stack for variadic cfuncs, so we shouldn't care about the number of arguments.
Contributor
|
So it uses the Ruby stack for variadic C functions? |
Member
Author
|
Yes, we pass a pointer to the arguments, which are from the Ruby stack if calling from Ruby https://github.com/Shopify/yjit/blob/main/yjit_codegen.c#L3005-L3011 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a check to ensure we don't have to push args on the stack to call a cfunc with many args (we probably could support this, but will save that for a future PR). However we never need to use the stack for variadic cfuncs, so we shouldn't care about the number of arguments.
Found this side exit from one of the parsers in main in ruby/ruby-bench#40