Allow special case of expandarray with nil#202
Merged
maximecb merged 1 commit intoShopify:mainfrom Sep 7, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for expandarray being passed an explicit
nil. I'm really don't like this pattern but ragel seems to generate it.For example
to set
a,b, andcto nil. (🤮 I would prefera = b = c = nil)Fortunately, it's at least easy to implement by checking for a known nil type and pushing N
nils onto the stack.It's likely we could support this case for other non-array values being passed, but I'm not sure how common that is.
Found in the ragel generated mail parsers in ruby/ruby-bench#40