Skip to content

Added compatibility for MacOS and Linux.#2

Closed
jungli-billa-raj wants to merge 5 commits intoShripad735:mainfrom
jungli-billa-raj:main
Closed

Added compatibility for MacOS and Linux.#2
jungli-billa-raj wants to merge 5 commits intoShripad735:mainfrom
jungli-billa-raj:main

Conversation

@jungli-billa-raj
Copy link
Copy Markdown
Contributor

wrote two platform specific functions to look for yt-dlp binary.
In the old ensureManagedYtDlpPath(), we check for platform and execute the respective functions.

During build, a warning popped up:
" • file source doesn't exist from=/home/meoww/Projects/streamfetch/bin"
I placed the yt-dlp binary inside streamfetch/electron/bin and hence changed this too. bin directory in the project root is confusing.

This comment was marked as resolved.

@Shripad735
Copy link
Copy Markdown
Owner

@jungli-billa-raj First off, thank you so much for taking the time to put this together. Adding macOS and Linux support is a huge feature, and I really appreciate your contribution-it means a lot !

I'm currently away from my personal laptop for the week, so I can't merge this right away. I did take a quick glance through the changes, and while the platform-dispatching logic looks really good, I noticed a potential breaking change for Windows that we'll need to sort out.

It looks like the extraResources.from path in package.json was changed from "bin" to "electron/bin". Because getBundledBinaryPath() currently expects the binaries to be in the <project_root>/bin/ directory, this mismatch will cause the packaged Windows build to fail when trying to locate yt-dlp.exe.

Since Windows is the primary target right now, I want to be 100% sure this doesn't accidentally break the existing installation process or runtime. I'll need to pull the branch down to properly test it and ensure the cross-platform changes are safely applied without altering the Windows behavior.

I'll be back at my place this weekend and will dive into this in more detail then. Thanks again for the awesome work and your patience, I'll follow up this weekend !

@jungli-billa-raj
Copy link
Copy Markdown
Contributor Author

jungli-billa-raj commented Feb 24, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants