Added compatibility for MacOS and Linux.#2
Added compatibility for MacOS and Linux.#2jungli-billa-raj wants to merge 5 commits intoShripad735:mainfrom
Conversation
…l/bin or /home/meoww/.local/bin
… to 'electron/bin' to fix source file doesn't exist during build
|
@jungli-billa-raj First off, thank you so much for taking the time to put this together. Adding macOS and Linux support is a huge feature, and I really appreciate your contribution-it means a lot ! I'm currently away from my personal laptop for the week, so I can't merge this right away. I did take a quick glance through the changes, and while the platform-dispatching logic looks really good, I noticed a potential breaking change for Windows that we'll need to sort out. It looks like the extraResources.from path in package.json was changed from "bin" to "electron/bin". Because getBundledBinaryPath() currently expects the binaries to be in the <project_root>/bin/ directory, this mismatch will cause the packaged Windows build to fail when trying to locate yt-dlp.exe. Since Windows is the primary target right now, I want to be 100% sure this doesn't accidentally break the existing installation process or runtime. I'll need to pull the branch down to properly test it and ensure the cross-platform changes are safely applied without altering the Windows behavior. I'll be back at my place this weekend and will dive into this in more detail then. Thanks again for the awesome work and your patience, I'll follow up this weekend ! |
|
Hello, hope you are doing good.
You are right, I shouldn't have changed the directory as per my preferred
convention. There's nothing technical about that. Also, I should have
raised different PRs. I'll revert the extra dependency address to
<project_root>/bin/ .
Thank u.
…On Tue, Feb 24, 2026, 11:42 Shripad SK ***@***.***> wrote:
*Shripad735* left a comment (Shripad735/streamfetch#2)
<#2 (comment)>
@jungli-billa-raj <https://github.com/jungli-billa-raj> First off, thank
you so much for taking the time to put this together. Adding macOS and
Linux support is a huge feature, and I really appreciate your
contribution-it means a lot !
I'm currently away from my personal laptop for the week, so I can't merge
this right away. I did take a quick glance through the changes, and while
the platform-dispatching logic looks really good, I noticed a potential
breaking change for Windows that we'll need to sort out.
It looks like the extraResources.from path in package.json was changed
from "bin" to "electron/bin". Because getBundledBinaryPath() currently
expects the binaries to be in the <project_root>/bin/ directory, this
mismatch will cause the packaged Windows build to fail when trying to
locate yt-dlp.exe.
Since Windows is the primary target right now, I want to be 100% sure this
doesn't accidentally break the existing installation process or runtime.
I'll need to pull the branch down to properly test it and ensure the
cross-platform changes are safely applied without altering the Windows
behavior.
I'll be back at my place this weekend and will dive into this in more
detail then. Thanks again for the awesome work and your patience, I'll
follow up this weekend !
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5TWDPXCXYLHAVTL5E4FZHD4NPTTNAVCNFSM6AAAAACV4LPPXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNBZGQYDKOJXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
wrote two platform specific functions to look for yt-dlp binary.
In the old ensureManagedYtDlpPath(), we check for platform and execute the respective functions.
During build, a warning popped up:
" • file source doesn't exist from=/home/meoww/Projects/streamfetch/bin"
I placed the yt-dlp binary inside streamfetch/electron/bin and hence changed this too. bin directory in the project root is confusing.