Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Conversation

@SamB440
Copy link
Contributor

@SamB440 SamB440 commented Mar 26, 2023

Updated to 1.19.4. Unsure if the version should be 3.0.0 or 2.9.1, I just followed what you did in previous commits.

Tested and can confirm it works:

  • /structureblock save/load correctly spawns the structure block
  • /structure saveworld correctly saves a structure to the world folder
  • /structure loadworld correctly loads the structure

Also checked obfuscation mappings on https://nms.screamingsandals.org/1.19.4/net/minecraft/world/level/block/entity/StructureBlockEntity.html, seems to be the same as 1.19/1.19.3.

Closes #109

Shynixn CI Actions and others added 30 commits June 11, 2021 08:39
Merge changes to master. --release
Merge changes to master. --release
Merge changes to master. --release
Merge changes to master --release
Merge changes to Master --release
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (37e6561) 46.51% compared to head (ea5dc2a) 46.51%.

❗ Current head ea5dc2a differs from pull request most recent head bd812e9. Consider uploading reports for the commit bd812e9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     46.51%   46.51%           
  Complexity      524      524           
=========================================
  Files            48       48           
  Lines          2296     2296           
  Branches        155      155           
=========================================
  Hits           1068     1068           
  Misses         1213     1213           
  Partials         15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@Shynixn Shynixn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help. Looks very good. I'll merge it later today.

Dockerfile Outdated
FROM amazoncorretto:17
# Change to the current plugin version present in build.gradle
ENV PLUGIN_VERSION=2.9.0
ENV PLUGIN_VERSION=3.0.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it will be 2.10.0 because it is only a minor change (3.x.x would indicate a breaking change).
However, I'll update that on my own, so it is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the other points where I changed the version didn't get pushed. Have fixed that now, and changed the version to 2.10.0.

@Shynixn Shynixn changed the base branch from master to development March 27, 2023 18:37
@Shynixn Shynixn merged commit b809f46 into Shynixn:development Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.19.4 Support

3 participants