-
Notifications
You must be signed in to change notification settings - Fork 4
Update to 1.19.4 #110
Update to 1.19.4 #110
Conversation
Demo release. --release
Merge changes to master.
Shynixn#73 Updated config files.
Shynixn#73 Updated config files.
Shynixn#73 Updated config files.
Shynixn#73 Updated config files.
Merge changes to master. --release
Shynixn#73 Updated config files. --release
Merge changes to master. --release
Merge changes to master. --release
Merge changes to master.
Merge changes to Master.
Removed obsolete notes.
Merge changes to master --release
Merge changes to Master
Merge changes to Master --release
Merge changes to Master.
Merge changes to Master --release
Merge changes to Master --release
Merge changes to Master --release
Merge changes to Master --release
Merge changes to Master --release
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=========================================
Coverage 46.51% 46.51%
Complexity 524 524
=========================================
Files 48 48
Lines 2296 2296
Branches 155 155
=========================================
Hits 1068 1068
Misses 1213 1213
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Shynixn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help. Looks very good. I'll merge it later today.
Dockerfile
Outdated
| FROM amazoncorretto:17 | ||
| # Change to the current plugin version present in build.gradle | ||
| ENV PLUGIN_VERSION=2.9.0 | ||
| ENV PLUGIN_VERSION=3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it will be 2.10.0 because it is only a minor change (3.x.x would indicate a breaking change).
However, I'll update that on my own, so it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the other points where I changed the version didn't get pushed. Have fixed that now, and changed the version to 2.10.0.
Updated to 1.19.4. Unsure if the version should be 3.0.0 or 2.9.1, I just followed what you did in previous commits.
Tested and can confirm it works:
/structureblock save/loadcorrectly spawns the structure block/structure saveworldcorrectly saves a structure to the world folder/structure loadworldcorrectly loads the structureAlso checked obfuscation mappings on https://nms.screamingsandals.org/1.19.4/net/minecraft/world/level/block/entity/StructureBlockEntity.html, seems to be the same as 1.19/1.19.3.
Closes #109