fix: handle unknown email gracefully in showSummary#11
Merged
Conversation
…t, used condition to set flash message, set 200 status code and stay on index.html
… without crashing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Problem
When a user submitted an email not found in clubs.json, the app crashed
with an IndexError 500. The [0] index was called on an empty list with
no error handling in place.
Root Cause
list comprehension + [0] assumed a match would always be found:
club = [club for club in clubs if club['email'] == request.form['email']][0]
Fix
Replaced [0] list indexing with next() and a None default, allowing the
absent case to be handled explicitly rather than crashing:
club = next((club for club in clubs if club['email'] == request.form['email']), None)
Added if not club guard to flash an error message and redirect back to
index.html without crashing.
Updated index.html and welcome.html to display flash messages.
Tests