Merged
Conversation
n8mgr
requested changes
Jul 10, 2025
Member
n8mgr
left a comment
There was a problem hiding this comment.
Lots of duplicated work here. Calling txn.ID() and getTransactionID() in every function is unnecessary.
Most of these methods only use the transaction to calculate the ID and access the slice. Instead of passing the transaction, you can pass exactly what you need:
func addMinerFees(tx *txn, txnID int64, []types.Currency)
func addSiacoinInputs(tx *txn, txnID int64, []types.SiacoinInput)
For the ones that need the transaction data to derive an ID, you should still pass the txn, but I'd recommend passing in the db ID as an additional arg instead of grabbing it. Goes for the V2 code as well.
…esult of txn.ID() where possible
n8mgr
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish #208 and remove the remaining maps that we used to map Sia IDs to internal database IDs.
christopher/clean-up-indexing-more:
master: