You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it is best to do it in Go vs JS because for v2 creating the contracts is already serious pain in the neck.
Update: We decided not to expose a special endpoint where the contract addresses could be retrieved. Instead, you can find the transaction where all the contracts were formed by looking at blocks until you find one containing a transaction where 3 contracts are formed. Then for instance you could query the state of those contracts using the explored API to get the expected state and compare that to what is displayed in the UI.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
It turns out that for the transition network, depending on how many renterd/walletd/hostd nodes we spin up, we might be before the require height or after it by the time the contract formation code runs. We could check the current height and decide to either form v1 contracts or v2 contracts, but that seems like it could cause confusion. So I just decided to disable contract formation on transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have network=v1 or network=v2, we will:
expiredContract)successfulContract)renewedContract)And expose these contract addresses via/fixtures/explored.Example successful response:Example unsuccessful response:I think it is best to do it in Go vs JS because for v2 creating the contracts is already serious pain in the neck.
Update: We decided not to expose a special endpoint where the contract addresses could be retrieved. Instead, you can find the transaction where all the contracts were formed by looking at blocks until you find one containing a transaction where 3 contracts are formed. Then for instance you could query the state of those contracts using the explored API to get the expected state and compare that to what is displayed in the UI.