Skip to content

Always show hazard or safety when played.#335

Merged
johnanvik merged 1 commit intomasterfrom
forceShowCards
Jun 13, 2018
Merged

Always show hazard or safety when played.#335
johnanvik merged 1 commit intomasterfrom
forceShowCards

Conversation

@johnanvik
Copy link
Copy Markdown
Collaborator

@johnanvik johnanvik commented Jun 13, 2018

Fixes #331

Overview of changes

  • Force safety and hazards cards to show when they are played.

Reviewer: @JaceRiehl

@johnanvik johnanvik added bug Unexpected behaviour of the game. gameplay Report is about an issue regarding playing the game. labels Jun 13, 2018
@johnanvik johnanvik requested a review from JaceRiehl June 13, 2018 20:18
@johnanvik johnanvik mentioned this pull request Jun 13, 2018
Closed
JaceRiehl
JaceRiehl approved these changes Jun 13, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JaceRiehl JaceRiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. I was too used to c++ not allowing to directly change class variables.

@johnanvik johnanvik merged commit 5feeef9 into master Jun 13, 2018
@johnanvik johnanvik deleted the forceShowCards branch June 13, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JaceRiehl JaceRiehl JaceRiehl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Unexpected behaviour of the game. gameplay Report is about an issue regarding playing the game.

Projects

None yet

Milestone

Game play Improvements (v. 1.7)

Development

Successfully merging this pull request may close these issues.

2 participants

@johnanvik @JaceRiehl