Skip to content

Merge dependency updates into a local branch to test before considering merging into master#543

Merged
strinsberg merged 19 commits intoSibylLab:dependecyUpdatesfrom
strinsberg:master
May 14, 2020
Merged

Merge dependency updates into a local branch to test before considering merging into master#543
strinsberg merged 19 commits intoSibylLab:dependecyUpdatesfrom
strinsberg:master

Conversation

@strinsberg
Copy link
Copy Markdown
Collaborator

This merge is from my fork for working on the major changes of updating project dependencies. It is not necessarily ready to be merged into the master branch yet. I need to ensure that it works on the SybilLab GitHub and can easily be transitioned to by other users before we consider merging into master.

Fixes #525 #514 #515

Overview of changes

  • Rebuilt project using @vue/cli to handle more of the dependencies
  • Only added dependencies back that were absolutely necessary. We may find some are missing, but we can add them as needed. Also, using the @vue/cli client moves a lot of the vue and webpack management into @vue/cli plugins or the tool itself. This reduces the number of things we are responsible for dealing with.
  • Added the new GitHub CI action for running tests on the project.
  • Updated unit tests to use Jest. This broke a few tests, but most are still intact. Only some of the assertion method names had to change in most cases. Jest is easily setup and integrated with the @vue/cli client and has the power for mocking/stubbing etc. built into it reducing the number of dependencies we need to add for those things. Jest also does coverage, but it is not yet integrated with the coveralls plugin that was used with the previous builds.

Reviewer: @strinsberg

strinsberg and others added 19 commits May 11, 2020 17:13
…e peice at a time. Removed everything and started adding things back to a basic working vue app. Currently just some classes and some store files have been added and imported to check them for proper running. The temp page runs while importing some of the js classes right now.
…nding page working. Had to modify some code a little. Also, added some of the configuration files back since their options are necessary for some of our code to work.
… being found. I was unable to get the card images to properly show up with the previous methods. This bypasses any webpack which I am not exactly sure how it will affect the program. It is probably not the 'best' method, but will do for now.
… some issues with build size. Not all fixes are the best, but have been made for now to get things working.
…. I had to add sinon as it was being used in the unit tests, but it may not be necessary as I beleive that jest has similar functionality built in. A couple of AI tests that sort the cards are no longer passing and I have no idea what this is about. I don't think anything I have done has changed their behaviour, but it will need to be looked into.
…have to install it gloabally to be able to work with the project.
…ing tests I beleive are a problem with the tests. These need to be changed and have been commented with some thoughts. The errors issued with teh card tests are a problem with testing with vuex. These tests will also need to be re-written to properly mock out objects or stub out getters. This has been commented with a link to the vue docs on testing with vuex. Now all tests are passing again.
…ed out tests. Gave some information why they are commented out and they will be fixed when the broken tests are fixed. I am leaving all this code for the moment to ensure that we can see what was intended from these tests when re-writting them. Also, removed some comments above tests that were essentially identical to the string given as the test name.
Main purpose is to test the current changes with some CI. Perhaps can be used to replace the Travis CI with the original setup if it makes things simpler and has the necessary features.
change style:lint name to the proper one
…ed the program-wars paper to the supportDocs folder.
@strinsberg strinsberg self-assigned this May 14, 2020
@strinsberg strinsberg merged commit 2d308d4 into SibylLab:dependecyUpdates May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant