AI for version 2.0 by strinsberg · Pull Request #574 · SibylLab/Program-Wars

strinsberg · 2020-06-12T21:54:38Z

Fixes #573

Overview of changes

Added AI players to the game
Built an AiHandler that uses a pattern like chain of responsibility and ActionHandler objects to make turn choices. This is extendable and will execute all given handlers in the order to find one that it can do.
Made a special ActionHandler that given a priority list will sort the cards in it's hand and play the best one it can. It uses another chain of responsibility like pattern but with methods instead of more objects. This handler is diverse enough to be used on it's own, but tweaking the card order or adding more action handlers in front of it can customize the AI
Created a factory class to allow creating new AiHandlers with different card orders (personalities). In the future it can be updated to have methods or params to create AI that use more than just the PlayBestCardAction handler.
Messages have been added to the message box to tell you what the AI did. Without putting some sleeps into the code the AI turn is instant, so currently It is possible to select and interact with AI opponent cards #541 is not so much of a problem, but will still need to be fixed.

Notes

The standard AI seems to be pretty competitive, so adjusting game length or making new setups that are easier for difficulties might be needed depending on the user base.
I have not added a random personality feature like we had in the previous game. We may want to add this back or use some kind of difficulty setting to allow setting different AI personalities.
test files for all AI classes and functions have been added.

…s of AI handlers.

…s hand every turn. Added a simple message event to track AI turns, it is a bit hack for now because of an issue and there is only one message so it won't refresh properly yet.

… hand based on a predefined card priority. Also, reverted the message box to use as once is really only once so it will not work.

…ng the best possible card. Not sure it is working as intended, but it does allow the ai player to play instruction and repeat cards.

…ction. Always plays the highest repeat on the biggest stack first, then plays biggest instruction.

…tart adding unit tests to confirm this properly, now that I think the class is not going to change in any big way except add functionality.

…rking as expected, without proper unit tests yet.

…very card type to the basic priority list.

…stCardAction class. They are working as expected with play testing.

…t work in the game and tested the algorithm elsewhere, but it is without formal unit tests yet.

…places if needed. Adjusted some documentation.

…the message box for AI turns so that it is mildly informative for now.

…differing personalities.

…ram-wars into Ai-version2.0-#573

…eally relevant for some newer changes and need to be rewritten.

… action objects and both type and personality.

…e the option of adding new actionHandlers to an AiHanlder in the future, but the PlayBestCardAction is quite competetive so far. Adjusted the comparator for lowest stacks that accept variables as the getTop() calls needed to use type. Adjusted tests to work with this.

…d in actions to make messages easier.

…not really need to be tested and worked differently on different machines.

…being instantiated twice?

…mplicated and uses dynamic programming, but it will give a much more consitent result and should not be a problem with running too long unless something very serious changes with our games group cards and how many stacks a player can get out during a game. Unit tests were re-written to test it better than before.

johnanvik

Very good. There is an incredible performance improvement in gameplay. We may want to consider putting a timer delay just so the player feels like the AI is actually considering its move!

strinsberg · 2020-06-15T19:13:48Z

Yes I have just created a new branch to address the AI cards being playable and added a small timer to allow for their turn to be "taken" as before. It is now sleeping in only one place so it is also easy to adjust to a time we like.

strinsberg · 2020-06-15T19:15:44Z

I have also found a couple of small bugs since submitting that I have taken care of in other branches that I will submit pull requests for once this is merged.

strinsberg added 30 commits June 10, 2020 14:36

Adding the very basic classes needed to make the new AI work.

03847d8

Added a very basic factory that will eventually return different type…

1344254

…s of AI handlers.

Added all that is necessary to get an AI handler working to redraw it…

b88380c

…s hand every turn. Added a simple message event to track AI turns, it is a bit hack for now because of an issue and there is only one message so it won't refresh properly yet.

Added the start of a class to handle playing the best card in an ai's…

ea6be77

… hand based on a predefined card priority. Also, reverted the message box to use as once is really only once so it will not work.

Added instruction and repeat handling to the action handler for playi…

9e3782d

…ng the best possible card. Not sure it is working as intended, but it does allow the ai player to play instruction and repeat cards.

Instructions and repeats are now working as expected in PlayBestCardA…

dd8f8ad

…ction. Always plays the highest repeat on the biggest stack first, then plays biggest instruction.

The PlayBestCardAction is now actually working as expected. Need to s…

b660c11

…tart adding unit tests to confirm this properly, now that I think the class is not going to change in any big way except add functionality.

Added variables to the PlayBestCardAction class. They appear to be wo…

09ec5c7

…rking as expected, without proper unit tests yet.

Added stubs for the rest of the best card methods, as well as added e…

f9994bd

…very card type to the basic priority list.

Implemented hacking for PlayBestCardAction.

f34c2be

Implemented the methods to play safety and attack cards in the PlayBe…

775d50b

…stCardAction class. They are working as expected with play testing.

Implemented a simple grouping algorithm for the AI. I have observed i…

2d67088

…t work in the game and tested the algorithm elsewhere, but it is without formal unit tests yet.

Moved some ai helpers to their own file so they can be used in other …

9fb72f0

…places if needed. Adjusted some documentation.

Cleaned a couple things up. Changed the message that is displayed in …

09f1e1f

…the message box for AI turns so that it is mildly informative for now.

Adjusted the way that factory sets type with card orders.

48d3f26

small changes.

a593bbf

Added a couple more card priority lists to give the AI some slightly …

1e3a0e6

…differing personalities.

Merge branch 'Ai-version2.0-#573' of https://github.com/SibylLab/prog…

e60f6a5

…ram-wars into Ai-version2.0-#573

Tests for some Ai classes. Removed some getters tests that were not r…

c755346

…eally relevant for some newer changes and need to be rewritten.

Tested RedrawAction and aiHelpers.

77c1b23

Added to the HandlerFactory to set things up for having a couple more…

97b9e0c

… action objects and both type and personality.

Started testing PlayBestCardAction.

d0a2f6f

Added more tests for PlayBestCardHandler

7af6182

Added more tests for PlayBestCardAction

8dad51f

Finished testing for PlayBestCardAction.

6d109a5

Added tests for the current AiHandlerFactory.

f00294c

lint errors autofixed

139f6da

Fixed some testing errors.

2e14a4c

Got messages working for the ai moves. Moved a couple of things aroun…

72a8add

…d in actions to make messages easier.

strinsberg requested a review from johnanvik June 12, 2020 21:54

strinsberg commented Jun 12, 2020

View reviewed changes

Comment thread src/components/game/MessageBox.vue

strinsberg added 4 commits June 12, 2020 16:03

fixed a unit test issue with an ambiguous order for sorting that did …

1420a68

…not really need to be tested and worked differently on different machines.

Added a fix for another error I think is being caused by message box …

b17e072

…being instantiated twice?

Removed a leftover console statement.

525aa31

johnanvik added this to the Sprint #2 (Summer 2020) milestone Jun 15, 2020

johnanvik reviewed Jun 15, 2020

View reviewed changes

Comment thread src/classes/ai/ActionHandler.js Outdated

johnanvik reviewed Jun 15, 2020

View reviewed changes

Comment thread src/classes/ai/aiHelpers.js Outdated

johnanvik approved these changes Jun 15, 2020

View reviewed changes

Fixed some review and lint errors.

6355fb6

strinsberg merged commit 533177f into master Jun 15, 2020

strinsberg deleted the Ai-version2.0-#573 branch June 15, 2020 19:31

johnanvik mentioned this pull request Jun 30, 2020

User Interface modifications #537

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AI for version 2.0#574

AI for version 2.0#574
strinsberg merged 35 commits intomasterfrom
Ai-version2.0-#573

strinsberg commented Jun 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnanvik left a comment

Uh oh!

strinsberg commented Jun 15, 2020

Uh oh!

strinsberg commented Jun 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

strinsberg commented Jun 12, 2020

Overview of changes

Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnanvik left a comment

Choose a reason for hiding this comment

Uh oh!

strinsberg commented Jun 15, 2020

Uh oh!

strinsberg commented Jun 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants