Skip to content

Stop user from playing ai turn #541#577

Merged
strinsberg merged 5 commits intomasterfrom
stopUserFromPlayingAiTurn-#541
Jun 15, 2020
Merged

Stop user from playing ai turn #541#577
strinsberg merged 5 commits intomasterfrom
stopUserFromPlayingAiTurn-#541

Conversation

@strinsberg
Copy link
Copy Markdown
Collaborator

Fixes #541, and bugs related to #573

Overview of changes

  • Fixed issue where it was possible to interact with the AI players hand or the redraw button on their turn.
  • In order to make this worth while I added some timeouts before and after an AI play to make it more obvious they have taken a move.
  • Fixed an issue with the updating of the TurnArea that was recreating a message box component every turn. Now it only creates once at game start and turn area only updates the cards displayed.

Reviewer: @johnanvik

…r them if we add time to make their turn more natural.
…so, put a sleep on the AI turn for 1.5 sec so that it feels a little more natural. This exposed the flaw that was in the message box, it was being recreated by it's parent because of a poorly placed :key. I fixed it and it now is only created once.
…e after acting to make playing against AI a little smoother.
@strinsberg strinsberg requested a review from johnanvik June 15, 2020 19:50
@strinsberg
Copy link
Copy Markdown
Collaborator Author

Once this is merged I can pull it into #575 and adjust the 4 player so that it is better to play.

@strinsberg strinsberg merged commit 4e771ba into master Jun 15, 2020
@strinsberg strinsberg deleted the stopUserFromPlayingAiTurn-#541 branch June 15, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It is possible to select and interact with AI opponent cards

2 participants