refactor: replaced manual byte formatting with format_bytes utility#44
Merged
SickleFire merged 2 commits intoJun 10, 2026
Merged
Conversation
SickleFire
approved these changes
Jun 10, 2026
SickleFire
left a comment
Owner
There was a problem hiding this comment.
Hi @law65horizon ,
Thank you for taking the time to update the codebase to use the new format_bytes implementation. This is a great cleanup effort and ensures consistency across the entire repository.
The changes look solid. Merging rn.
SickleFire
approved these changes
Jun 10, 2026
SickleFire
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
Replaced all manual byte formatting across the codebase with the existing
format_bytesutility fromsrc/utils/formatting.rs, as directed by the maintainer.Files changed:
src/main.rssrc/ui/commands.rssrc/ui/tui.rssrc/ui/render.rs— also removed the now-redundantformat_sizefunctionsrc/core/scan.rssrc/core/delta.rssrc/utils/mod.rs— added to expose the utils module