Skip to content

Generate man pages for linux mvis tool#62

Merged
SickleFire merged 2 commits into
SickleFire:devfrom
light89219:Generate-man-pages-for-Linux-mvis-tool
Jun 19, 2026
Merged

Generate man pages for linux mvis tool#62
SickleFire merged 2 commits into
SickleFire:devfrom
light89219:Generate-man-pages-for-Linux-mvis-tool

Conversation

@light89219

@light89219 light89219 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Generate man pages for linux mvis tool

Related issues

@SickleFire SickleFire requested a review from Samanyu-dev June 19, 2026 00:00
@SickleFire

SickleFire commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Hello @Samanyu-dev can you check out the Makefile just to make sure that it doesn't break what you did.

Thank you.

@SickleFire

Copy link
Copy Markdown
Owner

Hey @light89219 Looks good to me, and the man page looks professional, thank you for taking the time reading thru all the codebase, and coming up with the man page.

Just waiting for the approval of Samsie. and then I'll merge it

@Samanyu-dev

Samanyu-dev commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

hey @SickleFire @light89219 , Makefile changes will not break the automated macOS releases because our GitHub Actions (release.yml) use cargo commands directly, rather than relying on make

Screenshot 2026-06-19 at 9 35 29 AM the new build-release target in their Makefile does miss the macOS code signing step that was originally present in make build. If a macOS user runs make install locally, they'll get a broken, unsigned binary.

can we have a line like :
codesign --force --sign - --entitlements mvis.entitlements --timestamp=none target/release/mvis

@SickleFire

SickleFire commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Oh yeah, I missed that in our release.yml will fix that, I forgot to include your signing in our release.yml

@Samanyu-dev

Samanyu-dev commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

hey @SickleFire can we add macOS tests to be run alongside ubuntu and windows

current setup :
Screenshot 2026-06-19 at 9 53 22 AM
Screenshot 2026-06-19 at 9 53 44 AM

updated code:
Screenshot 2026-06-19 at 9 53 57 AM
Screenshot 2026-06-19 at 9 54 54 AM

code :
tests.yml : os: [ubuntu-latest, windows-latest, macos-latest]
release.yml :
line 27 add :

          - os: macos-latest
            target: x86_64-apple-darwin
            binary: mvis
            asset_name: mvis-macos-x86_64
          
          - os: macos-latest
            target: aarch64-apple-darwin
            binary: mvis
            asset_name: mvis-macos-aarch64 

then post - name: Build
run: cargo build --release --target ${{ matrix.target }} ( current line 50-51 add

- name: Sign binary (macOS)
        if: matrix.os == 'macos-latest'
        run: codesign --force --sign - --entitlements mvis.entitlements --timestamp=none target/${{ matrix.target }}/release/${{ matrix.binary }}

@SickleFire SickleFire merged commit d3dae99 into SickleFire:dev Jun 19, 2026
3 checks passed
@Samanyu-dev

Copy link
Copy Markdown
Collaborator

@SickleFire, add an issue to add macOS to tests and releases as I dont see the necessary code for it the latest repository code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants