[BUG] Previous developer accounts soft-locked by SideStore again

[duronald]

Describe the bug

This issue has come back. It was previously mentioned in issue #410 , and supposed to be fixed in pull #508, but has come back again for a while now.

Enrolling in the Developer Program removes the sideloading limits for an account even after your membership has expired. Because of this App IDs do not actually expire so for example I currently have 62 App IDs on my account, some from multiple years ago. The issue is that SideStore sees that I'm a "Free Developer Account" and assumes that I have the 10 App ID limit and shows "0 App IDs Remaining" and seems to make that check before any install so that I am unable to install any applications beside SideStore itself. If I install applications manually using AltServer (not SideServer since it revokes my certificate every time) then I'm able to have an infinite amount of applications installed at the same time with the 365 day expiry.

Instructions to reproduce

Become a member of Apple's Developer Program.
Let your membership lapse.
Use more App IDs than what is available with a free acount.
You're now locked from using SideStore.

What version of SideStore are you using?

0.6.2

Other info

This issue has come back. It was previously mentioned in issue #410 , and supposed to be fixed in pull #508, but has come back again for a while now.

[duronald]

Can someone walk me through the Github Actions build process? I believe I've identified the issue but don't have a Mac to build Sidestore. It seems like commit 3682b65 relative to 731d270#diff-d72de7a18a53e4a153f99f87a3c84513303aca9d574325e7b7aa216bcfa4800a reintroduced the issue with

else { throw ALTAppleAPIError(.maximumAppIDLimitReached) }

[duronald]

Or can someone generate a test build so I can try?

[duronald]

#1177

I built it and tested it and can confirm that the suspected regression was the cause.