Refactor unit traits and quantity definitions for improved readability#8
Merged
Conversation
Member
VPRamon
commented
May 8, 2026
VPRamon
commented
- Simplified unit_id() definitions in photon_radiance.hpp, spectral_photon_radiance.hpp, and spectral_radiance.hpp by removing unnecessary braces.
- Consolidated using directives for quantities in photon_radiance.hpp, spectral_photon_radiance.hpp, and spectral_radiance.hpp to enhance clarity and maintainability.
- Ensured consistent formatting across all unit definitions for better code consistency.
- Simplified unit_id() definitions in photon_radiance.hpp, spectral_photon_radiance.hpp, and spectral_radiance.hpp by removing unnecessary braces. - Consolidated using directives for quantities in photon_radiance.hpp, spectral_photon_radiance.hpp, and spectral_radiance.hpp to enhance clarity and maintainability. - Ensured consistent formatting across all unit definitions for better code consistency.
Reformatted spectral/photon radiance unit headers for consistency and reordered includes in literals.hpp to a logical grouping.
…ectral radiance headers - Updated unit_id() methods in UnitTraits for better readability by using block formatting. - Reformatted using statements for PhotonPerSquareCentimeterSecondSteradian and PhotonPerSquareCentimeterNanosecondSteradian in photon_radiance.hpp for consistency. - Enhanced formatting in spectral_radiance.hpp for ErgPerSecondSquareCentimeterSteradianAngstrom using block formatting in unit_id().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.