Skip to content

Port PSI add interval#86

Merged
jd-lara merged 10 commits intomainfrom
ac/add-interval
Apr 20, 2026
Merged

Port PSI add interval#86
jd-lara merged 10 commits intomainfrom
ac/add-interval

Conversation

@acostarelli
Copy link
Copy Markdown
Member

Thanks for opening a PR to PowerOperationsModels.jl, please take note of the following when making a PR:

Check the contributor guidelines

Anthony Costarelli and others added 5 commits April 17, 2026 15:45
IOM PR #71 changed interface functions from instance dispatch (::T) to
type dispatch (::Type{T}) for VariableType, ConstraintType, ExpressionType,
ParameterType, and formulation subtypes. This commit updates POM accordingly:

- Convert ~800+ call sites from SomeKey() to SomeKey for get_variable,
  get_expression, get_parameter, add_*_container!, lazy_container_addition!
- Convert all get_variable_binary/upper_bound/lower_bound/warm_start_value
  definitions to use ::Type{X} for variable and formulation args
- Convert objective function interfaces (proportional_cost,
  objective_function_multiplier, variable_cost, start_up_cost, etc.)
- Fix POM-local add_variables! overrides to extract formulation type via
  ::F where F pattern
- Add device type annotations to get_min_max_limits to resolve ambiguities
  with IOM default
- Update test helpers and test call sites

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@acostarelli acostarelli marked this pull request as ready for review April 17, 2026 21:04
@acostarelli acostarelli requested a review from jd-lara April 17, 2026 21:04
@jd-lara jd-lara merged commit 19fa912 into main Apr 20, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants