(For Mohammed) Add get session decisions#59
Merged
Conversation
Contributor
|
Can you fill up the description section please. Taking a look at the code now. |
mjouahri
reviewed
Jun 4, 2018
| @@ -1,3 +1,6 @@ | |||
| === 3.1.0 2018-06-04 | |||
| - Adds support for sessions decisions to [Decisions API](https://siftscience.com/developers/docs/curl/decisions-api) | |||
Contributor
There was a problem hiding this comment.
Maybe "get session decisions" is better wording. Depends are we returning all the decisions associated with a session or just the latest ?
Also do we have support for batch get sessions or just get session ?
Contributor
Author
There was a problem hiding this comment.
It's just get session, not batched
| # A Hash of optional parameters for this request -- | ||
| # | ||
| # :account_id:: | ||
| # Overrides the API key for this call. |
Contributor
There was a problem hiding this comment.
Can you update this to account id
mjouahri
approved these changes
Jun 4, 2018
Contributor
mjouahri
left a comment
mjouahri
left a comment
There was a problem hiding this comment.
LGTM! Please update the description before you merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Technical overview:
Testing Plan
Deployment