Closed
Conversation
ahmadshaheer
force-pushed
the
feat/add-pagination-component
branch
from
a83df8c to
871b151
Compare
YounixM
reviewed
Oct 28, 2024
| } from "@signozhq/pagination"; | ||
|
|
||
| const PaginationComponent = () => ( | ||
| <Pagination> |
Member
There was a problem hiding this comment.
@ahmadshaheer : Can we use the component similar to how the consuming application will be using?
Member
There was a problem hiding this comment.
like
<Pagination align="end" defaultCurrent={1} total={50} />
Member
There was a problem hiding this comment.
Check https://ant.design/components/pagination for examples
Member
|
@ahmadshaheer : the story should list all the props the component accepts. |
ahmadshaheer
force-pushed
the
feat/add-pagination-component
branch
from
b7d5fc3 to
ea2e30b
Compare
ahmadshaheer
force-pushed
the
feat/add-pagination-component
branch
from
ea2e30b to
bade620
Compare
GeekBoySupreme
suggested changes
Mar 26, 2025
GeekBoySupreme
left a comment
GeekBoySupreme
left a comment
There was a problem hiding this comment.
- Are we using Lucide icons here for the chevrons? Idk why the strokes looked very thin and similar to Ant-D icons for me 🤔
- Border radius needs to be reduced. Please cross-check with the design.
ahmadshaheer
force-pushed
the
feat/add-pagination-component
branch
from
bade620 to
912e2a3
Compare
Contributor
Author
|
closing in favor of #50, @GeekBoySupreme, I have addressed your comments there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.