Fix: 圧縮 by Sigma-project · Pull Request #12 · Sigma-project/misskey

Sigma-project · 2026-03-04T16:26:20Z

No description provided.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-03-04T16:26:25Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot

Pull request overview

This PR updates the frontend uploader’s image preprocessing capabilities by expanding which image MIME types are considered “image-editable” and by adjusting the resolution limits used for image compression presets.

Changes:

Expand IMAGE_EDITING_SUPPORTED_TYPES to include AVIF/GIF/BMP/APNG.
Adjust compression preset max dimensions for levels 2–4 (e.g., level 2 up to 4096×4096).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T16:30:08Z

+	'image/avif',
+	'image/gif',
+	'image/bmp',
+	'image/apng',


Adding image/gif/image/apng to IMAGE_EDITING_SUPPORTED_TYPES makes these files eligible for watermark/image-frame preprocessing and the edit menu. The watermark/frame pipeline renders via canvas and exports image/png, which will silently flatten animated images and change the file format; with a default watermark preset this can happen automatically on upload. Consider excluding animated formats from this list, or explicitly detect animation up-front and skip/disable watermark/frame/edit operations (or warn), and ensure uploadName/extension is updated when the output mime type changes.

Suggested change

'image/apng',

Copilot · 2026-03-04T16:30:09Z

+	'image/bmp',
+	'image/apng',


image/bmp and image/apng are now treated as editable/preprocessed types, but they are not included in THUMBNAIL_SUPPORTED_TYPES, so newly added BMP/APNG uploads won’t get a preview thumbnail (thumbnail stays null) until they’re converted to a supported type. If previews are expected, add these mime types to THUMBNAIL_SUPPORTED_TYPES (or provide a fallback thumbnail strategy).

Sigma-project · 2026-05-26T16:08:31Z

@codex レビューして

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe39a14517

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-26T16:11:52Z

 	'image/jpeg',
 	'image/png',
 	'image/webp',
+	'image/avif',


Exclude AVIF from lossy image-editing path

Adding image/avif to IMAGE_EDITING_SUPPORTED_TYPES routes AVIF files through preprocessForImage, but the animation guard there relies on is-file-animated, which only detects GIF/PNG/WebP. For animated AVIF uploads (with non-zero compression, including the default level 1), the code will treat them as non-animated and re-encode from createImageBitmap, effectively uploading a single-frame still image and losing animation.

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Sigma-project · 2026-05-26T16:23:22Z

@codex レビューして

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 484f76ece3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-26T16:29:34Z

+// ISOBMFF の ftyp ボックスを読み、AVIF アニメーション用ブランド `avis` の有無で判定する。
+// is-file-animated は GIF/PNG/WebP しか判定できないため、AVIF を別途扱う必要がある。
+async function isAnimatedAvif(file: Blob): Promise<boolean> {
+	const headerSize = Math.min(file.size, 64);


Parse full ftyp brands before classifying AVIF as static

The AVIF animation check only reads the first 64 bytes, so any valid file whose ftyp box is larger and places avis later in compatible_brands will be misclassified as non-animated. In that case use-uploader will still run watermark/frame/compression paths and collapse an animated AVIF into a single-frame image. Since boxSize is already parsed, this should read enough bytes to cover the whole ftyp box (or at least all declared brands) instead of hard-capping at 64 bytes.

Useful? React with 👍 / 👎.

64バイト固定読みでは compatible_brands に avis が後方にある場合に誤判定するため、boxSize に基づいてボックス全体を読み直す。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

@@ -630,7 +636,7 @@ export function useUploader(options: {

 		let preprocessedFile: Blob | File = item.file;

-		const needsWatermark = item.watermarkLayers != null && IMAGE_EDITING_SUPPORTED_TYPES.includes(preprocessedFile.type) && $i.policies.watermarkAvailable;
+		const needsWatermark = item.watermarkLayers != null && IMAGE_EDITING_SUPPORTED_TYPES.includes(preprocessedFile.type) && $i.policies.watermarkAvailable && !(await isFileAnimated(preprocessedFile));


+	'image/gif',
+	'image/bmp',
+	'image/apng',


+	const headerBuffer = await file.slice(0, 8).arrayBuffer();
+	const headerView = new DataView(headerBuffer);
+	const decoder = new TextDecoder('ascii');
+
+	if (decoder.decode(new Uint8Array(headerBuffer, 4, 4)) !== 'ftyp') return false;
+
+	let boxSize = headerView.getUint32(0);
+	// boxSize === 0: ボックスがファイル末尾まで続く / boxSize === 1: 直後に 64bit largesize（ftyp ではまず存在しない）
+	if (boxSize === 0 || boxSize === 1) boxSize = file.size;
+	const readSize = Math.min(boxSize, file.size, FTYP_READ_CAP);
+	if (readSize < 12) return false;
+
+	const buffer = await file.slice(0, readSize).arrayBuffer();
+	const bytes = new Uint8Array(buffer);
+
+	if (decoder.decode(bytes.subarray(8, 12)) === 'avis') return true;
+
+	for (let offset = 16; offset + 4 <= readSize; offset += 4) {


+export async function isFileAnimated(file: Blob): Promise<boolean> {
+	if (file.type === 'image/avif') {
+		return isAnimatedAvif(file);
+	}
+	return isAnimated(file);
+}


Sigma-project · 2026-05-26T16:44:24Z

@codex レビューして

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a059fbb74a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-26T16:49:12Z

 	'image/png',
 	'image/webp',
+	'image/avif',
+	'image/gif',


Exclude animated GIFs from image-editing type whitelist

Adding image/gif to IMAGE_EDITING_SUPPORTED_TYPES makes animated GIFs eligible for the generic edit menu (cropImageFile and image effector), but those flows render through canvas and output a single-frame blob, so animation is silently lost after editing. This is a regression from the previous behavior (GIFs were not in the editing whitelist) and will affect users who try to crop/effect animated GIF uploads.

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

isFileAnimated を 3 回呼んでいた箇所を 1 回化。アニメ画像は createImageBitmap も含めて前処理を全スキップし、設定済みの watermarkLayers/imageFrameParams をクリアする。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

canvas 経由の処理は 1 フレーム化されるためアニメ画像では効果がない。設定だけが残り適用されない混乱を避けるため、メニュー自体を出さない。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

boxSize === 1 のとき直後の 64bit largesize を読み、brands のオフセットを 16/24 起点に調整する。ftyp 範囲外を走査しなくなるため無関係な領域に `avis` が現れた場合の誤判定を防ぐ。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

major_brand/compatible_brands の avis 検出、ftyp が 64 バイトを超えるケース、64bit largesize、非 ftyp ヘッダー、短すぎる入力をカバーする。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Sigma-project and others added 3 commits March 5, 2026 01:02

feat: 画像圧縮の解像度設定を変更（高:4096, 中:2560, 低:1920）

27b84d4

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: 画像圧縮対応フォーマットにAVIF,GIF,BMP,APNGを追加

5e39f7b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge branch 'master' into feat/default-jxl-lossless

fe39a14

Sigma-project self-assigned this Mar 4, 2026

Copilot AI review requested due to automatic review settings March 4, 2026 16:26

github-actions Bot added the packages/frontend label Mar 4, 2026

Copilot started reviewing on behalf of Sigma-project March 4, 2026 16:26 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Sigma-project and others added 5 commits May 27, 2026 01:20

feat: AVIF対応のアニメーション判定ヘルパー isFileAnimated を追加

60f3ce9

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

fix: 画像圧縮のアニメーション判定を isFileAnimated に置換しAVIFアニメ対応

aa22473

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

fix: watermark処理にアニメーション画像スキップ判定を追加

335c545

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

fix: image-frame処理にアニメーション画像スキップ判定を追加

ec10ae6

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

fix: THUMBNAIL_SUPPORTED_TYPES に BMP/APNG を追加

484f76e

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Sigma-project requested a review from Copilot May 26, 2026 16:33

Copilot started reviewing on behalf of Sigma-project May 26, 2026 16:33 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

Sigma-project and others added 5 commits May 27, 2026 01:52

feat: UploaderItem に isAnimated フラグを追加

8b0d675

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Sigma-project mentioned this pull request May 26, 2026

JXL 移行による regression: sensitive スキャン / Docker libvips / tutorial アセット #15

Open

3 tasks

Sigma-project merged commit 990dc62 into master May 26, 2026
22 checks passed

Conversation

Sigma-project commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Sigma-project commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Sigma-project commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Sigma-project commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants