Preserve type when slicing SigmaCasedString #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slicing a
SigmaCasedStringcurrently returns aSigmaString. This PR preserves the concrete type so thatSigmaCasedStringremainsSigmaCasedStringafter slicing, matching the behaviour of otherSigmaStringoperations.Motivation
Downstream code may rely on the specific string subtype. For example, in
conversion/base.py L1677we're explicitly working withSigmaCasedString, but a slice converts it toSigmaString. Subsequent functions (e.g.convert_value_str()) then lose the ability to detect the original type.Behaviour
The current behaviour is:
The new behaviour is:
Two simple tests have been added to cover this behaviour.