-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Export deprecated rules in JSON #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export deprecated rules in JSON #5402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ariel-anieli 👋
It looks like this is your first pull request on the Sigma rules repository!
Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the Sigma community! 😃
718e818 to
ed9493c
Compare
Some rules were missed out in the CSV. Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Scaffold for an upcoming commit. Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
The JSON format is added as option of --format. Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Changed README, uploaded deprecated rules in JSON. Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Linting chore. Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
ed9493c to
7ebaa1c
Compare
|
Hi @ariel-anieli, I am curious about the motivation to add this? What is your use case? |
Hi @phantinuss, thanks for your feedback. My aim was to improve the developer experience. Does this fit into the roadmap of the project? Please let me know; if not, I'll then drop the PR. |
|
I am just curious about how or if these files are used as I know of no feedback. In general I don't like adding complexity for no reason but you write clean and readable code and the work is already done. So ofc we will make use of it. But I cannot promise that it will always be the case. I made two changes: Thanks for contributing. If you are looking for ways to contribute to the Sigma project, maybe you want to join the discord server and can ask/discuss for ways to do so. |
Sure, I do understand that. Thanks for your feedback.
Wonderful.
Of course, @phantinuss; I have just joined the server. See you there! |
Summary of the Pull Request
Hello maintainers,
This is my first ever PR to the project; your feedback is much appreciated.
I have added JSON as export format for deprecated rules.
Changelog
chore: tests/deprecated_rules.py - add json output format
chore: add deprecated/deprecated.json
chore: update README and workflow job accordingly
Example Log Event
Fixed Issues
SigmaHQ Rule Creation Conventions