Skip to content

Conversation

@ariel-anieli
Copy link
Contributor

@ariel-anieli ariel-anieli commented May 4, 2025

Summary of the Pull Request

Hello maintainers,

This is my first ever PR to the project; your feedback is much appreciated.

I have added JSON as export format for deprecated rules.

Changelog

chore: tests/deprecated_rules.py - add json output format
chore: add deprecated/deprecated.json
chore: update README and workflow job accordingly

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Maintenance Related to additions and update of the repository features labels May 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ariel-anieli 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@ariel-anieli ariel-anieli force-pushed the refactor-add-json-deprecated-rules branch from 718e818 to ed9493c Compare May 17, 2025 12:27
@nasbench nasbench requested a review from phantinuss June 4, 2025 16:56
Some rules were missed out in the CSV.

Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Scaffold for an upcoming commit.

Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
The JSON format is added as option of --format.

Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Changed README, uploaded deprecated rules in JSON.

Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Linting chore.

Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
@ariel-anieli ariel-anieli force-pushed the refactor-add-json-deprecated-rules branch from ed9493c to 7ebaa1c Compare June 8, 2025 17:08
@phantinuss
Copy link
Collaborator

Hi @ariel-anieli,

I am curious about the motivation to add this? What is your use case?

@ariel-anieli
Copy link
Contributor Author

Hi @ariel-anieli,

I am curious about the motivation to add this? What is your use case?

Hi @phantinuss, thanks for your feedback. My aim was to improve the developer experience.

Does this fit into the roadmap of the project? Please let me know; if not, I'll then drop the PR.

@phantinuss
Copy link
Collaborator

phantinuss commented Jun 13, 2025

I am just curious about how or if these files are used as I know of no feedback. In general I don't like adding complexity for no reason but you write clean and readable code and the work is already done. So ofc we will make use of it. But I cannot promise that it will always be the case.

I made two changes:
a) if modified doesn't exist, we use date over now() as the script is regularly run and I don't want to have diffs to show up for these rules (I also updated the workflow accordingly)
b) I added a secondary sort key as different systems/python versions will probably sort non-deterministically for rules that use the same modified date

Thanks for contributing. If you are looking for ways to contribute to the Sigma project, maybe you want to join the discord server and can ask/discuss for ways to do so.

@phantinuss phantinuss merged commit a1c9827 into SigmaHQ:master Jun 13, 2025
1 check passed
@ariel-anieli
Copy link
Contributor Author

I am just curious about how or if these files are used as I know of no feedback. In general I don't like adding complexity for no reason but you write clean and readable code and the work is already done. So ofc we will make use of it. But I cannot promise that it will always be the case.

Sure, I do understand that. Thanks for your feedback.

I made two changes: a) if modified doesn't exist, we use date over now() as the script is regularly run and I don't want to have diffs to show up for these rules (I also updated the workflow accordingly) b) I added a secondary sort key as different systems/python versions will probably sort non-deterministically for rules that use the same modified date

Wonderful.

Thanks for contributing. If you are looking for ways to contribute to the Sigma project, maybe you want to join the discord server and can ask/discuss for ways to do so.

Of course, @phantinuss; I have just joined the server. See you there!

@ariel-anieli ariel-anieli deleted the refactor-add-json-deprecated-rules branch June 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Related to additions and update of the repository features Rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants