Webpush notifications#2
Merged
senbar merged 1 commit intoSigmaProductions:developmentfrom Feb 1, 2024
Merged
Conversation
Changed handling of returning no result queries from returning some wild null values unsupported by F# to try catching not OrDefault query and returning Option. Added webpush implemented with C# webpush lib. Its super annoying rn though, theres no limitng on notifications so it will spam users even on their own messages. Added table for storing subscription instances which probably can use some work- maybe put it for each user no reason to hold old ones. Added commented out admin endpoint for testing webpush sending message to everyone. Added ignore rule to gitignore for appsettings for specific env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed handling of returning no result queries from returning some wild null values unsupported by F# to try catching not OrDefault query and returning Option.
Added webpush implemented with C# webpush lib. Its super annoying rn though, theres no limitng on notifications so it will spam users even on their own messages. Added table for storing subscription instances which probably can use some work- maybe put it for each user no reason to hold old ones.
Added commented out admin endpoint for testing webpush sending message to everyone. Added ignore rule to gitignore for appsettings for specific env.