Skip to content

Simplify CI#120

Merged
SignatureBeef merged 2 commits intoSignatureBeef:upcomingfrom
Arthri:ci/simplify
Jun 17, 2023
Merged

Simplify CI#120
SignatureBeef merged 2 commits intoSignatureBeef:upcomingfrom
Arthri:ci/simplify

Conversation

@Arthri
Copy link
Copy Markdown
Contributor

@Arthri Arthri commented Jun 15, 2023

  • Simplified CI by deduplicating jobs using Actions' matrixes
  • Unified zipping program to 7z(it is installed in all three runners Actions supports)
  • Fixed Windows' Launcher zip starting with publish
  • Fixed Linux's launcher zip starting with bin/Release/net6.0/ubuntu.16.04-x64/publish

@SignatureBeef
Copy link
Copy Markdown
Owner

This looks great to me. I've also added actions/setup-dotnet@v3 to settings now, so jobs should be able to run with this now too...hopefully.

@Arthri
Copy link
Copy Markdown
Contributor Author

Arthri commented Jun 15, 2023

Reopening to retrigger CI

@Arthri Arthri closed this Jun 15, 2023
@Arthri Arthri reopened this Jun 15, 2023
@Arthri
Copy link
Copy Markdown
Contributor Author

Arthri commented Jun 16, 2023

Sorry, I forgot to fix the working directory thing with ModFramework

@Arthri
Copy link
Copy Markdown
Contributor Author

Arthri commented Jun 16, 2023

As far as I can tell, the previous run was not able to load the C# modules, signified by the lack of [CSharp] logs that are normally there. Causing MonoMod to crash

@SignatureBeef SignatureBeef merged commit 59b06f3 into SignatureBeef:upcoming Jun 17, 2023
@SignatureBeef
Copy link
Copy Markdown
Owner

Latest build appears to be ok now, i think, Really dig the changes, haven't really had time to improve stuff like this myself so thank you 🙏

@Arthri Arthri deleted the ci/simplify branch April 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants