Conversation
Greptile SummaryThis PR adds
Confidence Score: 4/5Hold for the incomplete JSON escaping fix — the current One P1 finding (incomplete src/Silisizer.cpp — Important Files Changed
Sequence DiagramsequenceDiagram
participant TCL as Tcl Script
participant SWIG as Silisizer.i (SWIG)
participant Main as main.cpp (dump_icg_json)
participant Impl as Silisizer.cpp (dumpIcgJson)
participant STA as sta::Sta / sta::Network
participant FS as JSON File
TCL->>SWIG: dump_icg_json(path)
SWIG->>Main: dump_icg_json(path)
Main->>Impl: silisizer::dumpIcgJson(path)
Impl->>STA: sta::Sta::sta()
Impl->>STA: sta->clockGatedRegisters()
STA-->>Impl: list of gated flip-flops
Impl->>FS: write gated_flops array
Impl->>STA: network->leafInstanceIterator()
loop each leaf instance
Impl->>STA: network->cell(inst)
Impl->>STA: network->libertyCell(cell)
STA-->>Impl: LibertyCell*
Impl->>Impl: lc->isClockGate() ?
Impl->>FS: write ICG entry (pathName to libertyCell name)
end
Impl->>FS: close JSON object
Reviews (1): Last reviewed commit: "fix" | Re-trigger Greptile |
akashlevy
requested changes
Apr 22, 2026
akashlevy
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumps an ICG json in specified path to store all relevant information about ICGs.
Stores flip-flops connected to an ICG and ICG instances (mapped to their liberty names)