Conversation
these files are generated by generate_extended_schema.py but weren't up-to-date on the repo. Only changes are small typo fixes inside strings.
| shape: | ||
| - 2 | ||
| doc: ' the 2d imaging frame size in voxels' | ||
| doc: the 2d imaging frame size in voxels |
There was a problem hiding this comment.
Unrelated to these changes, but is this really voxels if we're imaging in 2d?
There was a problem hiding this comment.
Yea, it's debatable, I think... I could be wrong, but you could argue that since we are looking at a 3D image stack overall the data points we are looking at are voxels, and each imaging frame has, therefore, frame_size[0] voxels in one direction, and frame_size[1] voxels in the other. Guess it depends whether you want to emphasize the fact that the data points are 3d or that the frame is 2d more strongly?
ageorgou
left a comment
ageorgou
left a comment
There was a problem hiding this comment.
Looks reasonable, just need to update the signatures to match!
alessandrofelder
force-pushed
the
update-extension-yamls
branch
from
0ee0d58 to
497d9af
Compare
these needed updating due to both: * the silverlab extension having changed (typo fix in `generate_extended_schema.py` was not propagated to extension yaml files) * the previous changes to metadata like switching to `ruamel.yaml` and writing pynwb defaults to file instead of parameter explanations
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 53.76% 53.69% -0.07%
==========================================
Files 12 12
Lines 1581 1583 +2
Branches 252 253 +1
==========================================
Hits 850 850
- Misses 696 697 +1
- Partials 35 36 +1
Continue to review full report at Codecov.
|
|
Not sure why the Travis tests aren't linked properly, but they're passing. |
3 participants
The files
silverlab.*.yamlare generated by generate_extended_schema.pybut weren't up-to-date on the repo.
Only changes are small typo fixes inside strings. This affects the signatures, however!
Also, fixes problems with newer versions of
tifffile, which don't include the indirect dependencyimagecodecsby default anymore.