Why are we using Quadrature_modifier_* in the niederer CEP benchmark?

[zasexton]

@michelebucelli @kko27 @ktbolt I believe we should omit these modifier arguments from the input files if we do not know why we are including them in the first place. Additionally, my understanding is that these Quadrature_modifier_TRI3 and Quadrature_modifier_TET4 change the quadrature behavior of the simplex elements but the test cases here use brick elements?

[zasexton]

svMultiPhysics/tests/cases/cep/niederer_benchmark_ECGs_quadrature/solver_BICG_CN_epicardium_BO.xml

Lines 28 to 64 in 0337748

	<Mesh_file_path> mesh/h0.1/mesh-complete.mesh.vtu </Mesh_file_path>
	<Add_face name="X0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="X1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Fiber_direction> (1, 0, 0) </Fiber_direction>
	<Domain_file_path> mesh/h0.1/domain_info.dat </Domain_file_path>
	<Quadrature_modifier_TET4> 0.34 </Quadrature_modifier_TET4>

svMultiPhysics/tests/cases/cep/niederer_benchmark_ECGs_quadrature/solver_CG_RK4_myocardium_BO.xml

Lines 30 to 64 in 0337748

	<Add_face name="X0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="X1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Fiber_direction> (1, 0, 0) </Fiber_direction>
	<Domain_file_path> mesh/h0.1/domain_info.dat </Domain_file_path>
	<Quadrature_modifier_TET4> 0.34 </Quadrature_modifier_TET4>

svMultiPhysics/tests/cases/cep/niederer_benchmark_ECGs_quadrature/solver_GMRES_FE_epicardium_TTP.xml

Lines 30 to 65 in 0337748

	<Add_face name="X0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="X1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Fiber_direction> (1, 0, 0) </Fiber_direction>
	<Domain_file_path> mesh/h0.1/domain_info.dat </Domain_file_path>
	<Quadrature_modifier_TET4> 0.34 </Quadrature_modifier_TET4>
	</Add_mesh>

svMultiPhysics/tests/cases/cep/niederer_benchmark_ECGs_quadrature/solver_GMRES_FE_pfib_AP.xml

Lines 26 to 65 in 0337748

	<Add_mesh name="msh" >
	<Mesh_file_path> mesh/h0.1/mesh-complete.mesh.vtu </Mesh_file_path>
	<Add_face name="X0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="X1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/X1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Y1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Y1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z0">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z0.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Add_face name="Z1">
	<Face_file_path> mesh/h0.1/mesh-surfaces/Z1.vtp </Face_file_path>
	<Quadrature_modifier_TRI3> 0.43 </Quadrature_modifier_TRI3>
	</Add_face>
	<Fiber_direction> (1, 0, 0) </Fiber_direction>
	<Domain_file_path> mesh/h0.1/domain_info.dat </Domain_file_path>
	<Quadrature_modifier_TET4> 0.34 </Quadrature_modifier_TET4>
	</Add_mesh>

[ktbolt]

@zasexton @michelebucelli @kko27 The quadrature changes were made by @MatteoSalvador for the New features for CEP
Issue.

The mesh used by svMultiPhysics/tests/cases/cep/niederer_benchmark_ECGs_quadrature are indeed bricks so it is not clear why the Quadrature_modifier were added to the solver XML files.

[zasexton]

I'll open an issue to remove these then. Otherwise these seem to be confusing in the current testing infrastructure.

[michelebucelli]

Sounds good to me! I wasn't sure about the meaning of those tags so I never touch them when modifying the tests.