Skip to content

Conversation

@dseyler
Copy link
Contributor

@dseyler dseyler commented Jul 29, 2025

Cardiac Mechanics Benchmark test cases

Current situation

Added two new test cases (struct + ustruct) based on this cardiac elastodynamics benchmark paper . This addresses [issue 347] (#347).

Release Notes

  • Added struct/LV_HolapfelOgden_active and uruct/LV_HolapfelOgden_active test case
  • Test cases include plots from the benchmark paper as well as a PV loop.
  • Includes scripts to generate pressure and active stress waveforms as well as post processing script.

Code of Conduct & Contributing Guidelines

Copy link
Collaborator

@aabrown100-git aabrown100-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just made a few suggestions for things to change.

Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the Mesh_scale_factor parameter, it does not do anything.

…mple, and improve plotting for svMultiPhysics comparison
Copy link
Collaborator

@aabrown100-git aabrown100-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Nice job!

@aabrown100-git
Copy link
Collaborator

The code itself looks good. It's still failing the macos and linux tests. The macos issue seems to be affecting all current PRs. Not sure about the linux issue, I'm rerunning the linux test now.

@dseyler
Copy link
Contributor Author

dseyler commented Aug 21, 2025

@aabrown100-git @ktbolt Looks like it's still failing macos and linux. Any ideas why?

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.97%. Comparing base (c82c586) to head (157b772).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   65.88%   65.97%   +0.09%     
==========================================
  Files         163      163              
  Lines       31822    31822              
  Branches     5202     5202              
==========================================
+ Hits        20967    20996      +29     
+ Misses      10717    10688      -29     
  Partials      138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aabrown100-git aabrown100-git merged commit edee4b3 into SimVascular:main Aug 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants