-
Notifications
You must be signed in to change notification settings - Fork 46
Cardiac mechanics benchmark #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardiac mechanics benchmark #419
Conversation
aabrown100-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just made a few suggestions for things to change.
ktbolt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the Mesh_scale_factor parameter, it does not do anything.
…mple, and improve plotting for svMultiPhysics comparison
aabrown100-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! Nice job!
|
The code itself looks good. It's still failing the macos and linux tests. The macos issue seems to be affecting all current PRs. Not sure about the linux issue, I'm rerunning the linux test now. |
|
@aabrown100-git @ktbolt Looks like it's still failing macos and linux. Any ideas why? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 65.88% 65.97% +0.09%
==========================================
Files 163 163
Lines 31822 31822
Branches 5202 5202
==========================================
+ Hits 20967 20996 +29
+ Misses 10717 10688 -29
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cardiac Mechanics Benchmark test cases
Current situation
Added two new test cases (struct + ustruct) based on this cardiac elastodynamics benchmark paper . This addresses [issue 347] (#347).
Release Notes
Code of Conduct & Contributing Guidelines