inlet and outlet text files for fab#65
Merged
zasexton merged 4 commits intoSimVascular:mainfrom Mar 14, 2026
Merged
Conversation
Co-authored-by: Soham Sinha <sohams@DN0a25a05c.SUNet>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
This PR adds optional inlet/outlet root sidecar exports for spline files generated from trees and
forests in the GUI.
The existing spline export writes sampled spline points, but it does not provide a companion file
that identifies which root connection points should be treated as inlets or outlets for downstream
fabrication or perfusion workflows. This PR extends the export flow without changing the default
behavior: sidecar export is opt-in, tree exports require an explicit root role, and forest exports
use explicit per-network inlet tree indices so each generated spline file gets a matching
*_inlet_outlet.txtfile.Related issue / discussion: add link here if there is an existing upstream issue or discussion for
spline inlet/outlet sidecar export.
Release Notes
*_inlet_outlet.txt.network inlet tree indices for forest exports.
outlet root points.
tree forest, and invalid sidecar input cases.
explicitly enabled.
Documentation
The spline export dialog now includes an optional root sidecar export path. Documentation should
describe:
Export inlet/outlet root sidecaroption in the GUI*_inlet_outlet.txtfilename conventioninletx, y, zoutletx, y, zTesting
This change adds and updates regression tests in
test/test_spline_export_files.pyto cover:Local verification:
pytest -q test/test_spline_export_files.pyPlease ensure the full GitHub Actions test matrix also passes for this change.
Code of Conduct & Contributing Guidelines
CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/SimVascular/.github/blob/main/
CONTRIBUTING.md).