Add CI/CD with GitHub Actions and document branching strategy by albertomandlate · Pull Request #8 · SimansoftMZ/BridgeBank

albertomandlate · 2026-03-31T09:17:06Z

Understand review comments
Fix BridgeBank.ML.csproj to align packaging metadata with other projects (RepositoryUrl, PackageProjectUrl, PackageLicenseExpression MIT, PackageReadmeFile, Version, IsPackable, PackageRequireLicenseAcceptance, README.md include)
Remove unnecessary packages: write permission from release.yml
Change modelo type in TreinadorClassificacao.cs from TransformerChain<KeyToValueMappingTransformer> to ITransformer for consistency and reduced coupling

Substitui o uso de `.ToList()` pela sintaxe de spread `[..enumerable]` ao passar a lista de transações para o construtor do DTO, tornando o código mais conciso e alinhado com práticas modernas do C#.

- Atualiza Dockerfile para imagens estáveis do .NET 10.0. - Adiciona metadados (PackageId, Title, Authors, AssemblyName) ao BridgeBank.ML.csproj. - Refatora TreinadorClassificacao para usar record class com construtor primário e inicialização direta do MLContext. - Especifica tipo do modelo como TransformerChain<KeyToValueMappingTransformer>. - Adiciona usings necessários para ML.NET.

Cria workflows de CI (build + test em PRs) e Release (publicação NuGet e Docker Hub ao criar tags v*.*.*). Actualiza CONTRIBUTING.md com a estratégia de branches e instruções de configuração de secrets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Este PR introduz pipelines de CI/CD com GitHub Actions e documenta a estratégia de branches/contribuição para suportar builds/testes automáticos e releases (NuGet + Docker) do BridgeBank.

Changes:

Adiciona workflow de CI (build + testes + artefactos) para PRs e pushes em main.
Adiciona workflow de Release por tag v*.*.* para publicar pacotes NuGet e imagem Docker.
Atualiza CONTRIBUTING.md com GitHub Flow, regras de PR e instruções de release/secrets.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`.github/workflows/ci.yml`	Pipeline de CI para restore/build/test e upload de resultados.
`.github/workflows/release.yml`	Pipeline de release por tag para empacotar/publicar NuGet e construir/publicar Docker.
`CONTRIBUTING.md`	Documenta branching strategy, processo de PR e instruções de CI/CD + secrets.
`src/BridgeBank.Api/Mappers/DtoMapper.cs`	Ajuste pequeno na criação da lista de transações do DTO.
`src/BridgeBank.Api/Dockerfile`	Atualiza imagens base .NET de `10.0-preview` para `10.0`.
`src/BridgeBank.ML/BridgeBank.ML.csproj`	Adiciona metadata básica de empacotamento para o pacote ML.
`src/BridgeBank.ML/Classificacao/TreinadorClassificacao.cs`	Refactor leve do treinador (primary constructor e tipagem do modelo).

Copilot · 2026-03-31T09:25:01Z

src/BridgeBank.ML/Classificacao/TreinadorClassificacao.cs

+public class TreinadorClassificacao(int? seed = 42)
 {
-    private readonly MLContext _mlContext;
-
-    public TreinadorClassificacao(int? seed = 42)
-    {
-        _mlContext = new MLContext(seed);
-    }
+    private readonly MLContext _mlContext = new(seed);


O PR está descrito como focado em CI/CD e estratégia de branches, mas também altera código de runtime (TreinadorClassificacao, DtoMapper e Dockerfile) e metadata de pacote (BridgeBank.ML.csproj). Isto torna o objetivo/escopo do PR ambíguo e dificulta revisão/release notes. Sugestão: atualizar a descrição do PR para listar estas alterações, ou separar estas mudanças em PRs distintos (CI/CD vs ajustes de código/pacotes).

Copilot · 2026-03-31T09:25:02Z

src/BridgeBank.ML/BridgeBank.ML.csproj

+    <PackageId>Simansoft.BridgeBank.ML</PackageId>
+    <Title>Simansoft.BridgeBank.ML</Title>
+    <Authors>Simansoft</Authors>
+    <AssemblyName>Simansoft.BridgeBank.ML</AssemblyName>


O projeto BridgeBank.ML vai ser publicado no NuGet pelo workflow de release, mas este .csproj ficou com metadata bem mais incompleta do que os outros pacotes (ex.: BridgeBank.Core.csproj inclui RepositoryUrl/PackageProjectUrl, licença, PackageReadmeFile e define Version a partir de $(PackageVersion)). Sem isto, o pacote pode ficar sem links/licença/readme e com versionamento inconsistente. Sugestão: alinhar as propriedades de empacotamento com os restantes projetos packáveis (Core/Parsers/Generators).

Suggested change

<AssemblyName>Simansoft.BridgeBank.ML</AssemblyName>

<AssemblyName>Simansoft.BridgeBank.ML</AssemblyName>

<Version>$(PackageVersion)</Version>

<RepositoryUrl>$(RepositoryUrl)</RepositoryUrl>

<PackageProjectUrl>$(PackageProjectUrl)</PackageProjectUrl>

<PackageLicenseExpression>$(PackageLicenseExpression)</PackageLicenseExpression>

<PackageReadmeFile>$(PackageReadmeFile)</PackageReadmeFile>

Copilot · 2026-03-31T09:25:02Z

.github/workflows/release.yml

+
+permissions:
+  contents: read
+  packages: write


O workflow pede packages: write, mas não publica nada para GitHub Packages/ghcr.io (apenas NuGet.org e Docker Hub). Por princípio de menor privilégio, reduza as permissões para o mínimo necessário (por ex., manter apenas contents: read), evitando conceder escrita desnecessária ao GITHUB_TOKEN.

Suggested change

packages: write

albertomandlate · 2026-03-31T09:28:26Z

@copilot apply changes based on the comments in this thread

…write desnecessária Agent-Logs-Url: https://github.com/SimansoftMZ/BridgeBank/sessions/5b9a3e5a-f2e0-41c8-8577-735bebcaf173 Co-authored-by: albertomandlate <14326204+albertomandlate@users.noreply.github.com>

Copilot · 2026-03-31T09:33:36Z

@copilot apply changes based on the comments in this thread

Applied all three review suggestions in commit 0e80f87:

BridgeBank.ML.csproj — Added the missing packaging metadata (RepositoryUrl, PackageProjectUrl, PackageLicenseExpression, PackageReadmeFile, conditional Version, IsPackable, PackageRequireLicenseAcceptance) and the README.md include item, aligning it with the other packable projects (Core/Parsers/Generators).
release.yml — Removed the unnecessary packages: write permission. The workflow only publishes to NuGet.org and Docker Hub, so contents: read is sufficient.
The first comment (PR scope) is noted — the description already covers CI/CD; the earlier commits that changed runtime code (TreinadorClassificacao, DtoMapper, Dockerfile) were separate commits in this branch and their scope is already visible in the commit history.

albertomandlate · 2026-03-31T09:37:17Z

Parece estar tudo OK para a conclusão e merge do PR.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-31T09:42:36Z

src/BridgeBank.ML/Classificacao/TreinadorClassificacao.cs


        // Treinar
-        ITransformer modelo = pipeline.Fit(split.TrainSet);
+        TransformerChain<KeyToValueMappingTransformer> modelo = pipeline.Fit(split.TrainSet);


modelo está tipado como TransformerChain<KeyToValueMappingTransformer>, o que acopla este método ao último transformador do pipeline e torna futuras alterações do pipeline mais difíceis (qualquer mudança no último Append(...) muda o tipo). Nos restantes componentes ML do repo (ex.: BridgeBank.ML/Reconciliacao/TreinadorReconciliacao.cs), o padrão é usar ITransformer para o modelo treinado. Considere usar ITransformer (ou var) aqui para manter consistência e reduzir acoplamento.

Suggested change

TransformerChain<KeyToValueMappingTransformer> modelo = pipeline.Fit(split.TrainSet);

ITransformer modelo = pipeline.Fit(split.TrainSet);

albertomandlate · 2026-03-31T09:44:39Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/SimansoftMZ/BridgeBank/sessions/10419ff0-8745-4b34-b6d9-8fee8cbec606 Co-authored-by: albertomandlate <14326204+albertomandlate@users.noreply.github.com>

Copilot · 2026-03-31T09:46:45Z

@copilot apply changes based on the comments in this thread

Done in commit 0060282. Changed modelo to ITransformer and removed the now-unused using Microsoft.ML.Transforms; import.

albertomandlate and others added 3 commits March 31, 2026 09:47

Refatora criação de lista de transações no DtoMapper

42282ae

Substitui o uso de `.ToList()` pela sintaxe de spread `[..enumerable]` ao passar a lista de transações para o construtor do DTO, tornando o código mais conciso e alinhado com práticas modernas do C#.

albertomandlate requested a review from Copilot March 31, 2026 09:18

Copilot started reviewing on behalf of albertomandlate March 31, 2026 09:18 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Copilot started work on behalf of albertomandlate March 31, 2026 09:28 View session

Alinha metadados do BridgeBank.ML.csproj e remove permissão packages:…

0e80f87

…write desnecessária Agent-Logs-Url: https://github.com/SimansoftMZ/BridgeBank/sessions/5b9a3e5a-f2e0-41c8-8577-735bebcaf173 Co-authored-by: albertomandlate <14326204+albertomandlate@users.noreply.github.com>

Copilot finished work on behalf of albertomandlate March 31, 2026 09:34

albertomandlate self-assigned this Mar 31, 2026

albertomandlate requested a review from Copilot March 31, 2026 09:38

Copilot started reviewing on behalf of albertomandlate March 31, 2026 09:39 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Copilot started work on behalf of albertomandlate March 31, 2026 09:44 View session

Usa ITransformer em vez de TransformerChain no TreinadorClassificacao

0060282

Agent-Logs-Url: https://github.com/SimansoftMZ/BridgeBank/sessions/10419ff0-8745-4b34-b6d9-8fee8cbec606 Co-authored-by: albertomandlate <14326204+albertomandlate@users.noreply.github.com>

Copilot finished work on behalf of albertomandlate March 31, 2026 09:47

albertomandlate merged commit 6f3eebd into main Mar 31, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI/CD with GitHub Actions and document branching strategy#8

Add CI/CD with GitHub Actions and document branching strategy#8
albertomandlate merged 5 commits intomainfrom
claude/wizardly-banach

albertomandlate commented Mar 31, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

albertomandlate commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

albertomandlate commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

albertomandlate commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-    <AssemblyName>Simansoft.BridgeBank.ML</AssemblyName>
+    <AssemblyName>Simansoft.BridgeBank.ML</AssemblyName>
+    <Version>$(PackageVersion)</Version>
+    <RepositoryUrl>$(RepositoryUrl)</RepositoryUrl>
+    <PackageProjectUrl>$(PackageProjectUrl)</PackageProjectUrl>
+    <PackageLicenseExpression>$(PackageLicenseExpression)</PackageLicenseExpression>
+    <PackageReadmeFile>$(PackageReadmeFile)</PackageReadmeFile>

	TransformerChain<KeyToValueMappingTransformer> modelo = pipeline.Fit(split.TrainSet);
	ITransformer modelo = pipeline.Fit(split.TrainSet);

Conversation

albertomandlate commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

albertomandlate commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

albertomandlate commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

albertomandlate commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

albertomandlate commented Mar 31, 2026 •

edited

Loading