Skip to content

Alterar configuração de indentação do XML#31

Merged
albertomandlate merged 1 commit intodevelopfrom
feature-limpeza-de-codigo
May 22, 2025
Merged

Alterar configuração de indentação do XML#31
albertomandlate merged 1 commit intodevelopfrom
feature-limpeza-de-codigo

Conversation

@albertomandlate
Copy link
Copy Markdown
Contributor

Mudou a propriedade Indent de true para false na configuração do XmlWriterSettings. Isso resulta em uma saída XML mais compacta, sem indentação.

Mudou a propriedade `Indent` de `true` para `false` na configuração do `XmlWriterSettings`. Isso resulta em uma saída XML mais compacta, sem indentação.
@albertomandlate albertomandlate requested a review from Copilot May 22, 2025 16:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the XML writer settings to produce a more compact XML output by disabling indentation.

  • Modified the XmlWriterSettings in MozambiqueSaftGenerator.cs to set Indent from true to false.

XmlWriterSettings settings = new()
{
Indent = true,
Indent = false,
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment explaining the decision to disable indentation, which can help future maintainers understand the reasoning behind this configuration change.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ideia é de reduzir espaço no processo de gerar ficheiro. O ficheiro precisa de ocupar o menos espaço possível.

@albertomandlate albertomandlate requested a review from Copilot May 22, 2025 16:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adjust the XML writer settings to produce a more compact output by disabling indentation.

  • Set XmlWriterSettings.Indent from true to false for compact XML
Comments suppressed due to low confidence (3)

src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261

  • Verify and update any existing tests that assume indented XML output to accommodate the new compact format.
Indent = false,

src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261

  • [nitpick] Consider adding a comment explaining why indentation is disabled to clarify the intent for future maintainers.
Indent = false,

src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261

  • [nitpick] Disabling indentation may be a breaking change for consumers expecting human-readable XML; ensure downstream consumers can handle compact output or version the change accordingly.
Indent = false,

@albertomandlate albertomandlate requested a review from Copilot May 22, 2025 16:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the XML writer settings to produce a more compact output by disabling indentation.

  • Disabled Indent in XmlWriterSettings to remove extra whitespace.
Comments suppressed due to low confidence (2)

src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261

  • Since the output format changed, add or update unit tests to assert that the generated XML contains no indentation.
Indent = false,

src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261

  • [nitpick] Consider adding a comment or updating the method summary to explain that indentation has been disabled for compact XML generation.
Indent = false,

@albertomandlate albertomandlate merged commit 824f45e into develop May 22, 2025
1 check passed
@albertomandlate albertomandlate deleted the feature-limpeza-de-codigo branch May 22, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants