Added handling methods through mavlink#244
Merged
Merged
Conversation
Contributor
Michal-Mankowski
commented
Jun 8, 2025
Michal-Mankowski
commented
- Listening loop that read uart for the messages from mavlink.
- Checks the message id and does corresponding action.
- Sends ack after every method.
Mateusz-Krajewski
requested changes
Jul 7, 2025
Collaborator
Mateusz-Krajewski
left a comment
Mateusz-Krajewski
left a comment
There was a problem hiding this comment.
Ack wymaga zmiany dodającej informacje na jaką wiadomosc odpowiada. Pozatym poza kosmetycznymi zmianami jest ok
| } | ||
| } | ||
|
|
||
| void RadioApp::SendAck(uint8_t status) { |
Collaborator
There was a problem hiding this comment.
To trochę problem z definicja mavlink a nie twoja wina ale brakuje w ack jakiegoś id wiadomości którego ono dotyczy, żeby przy 5 wysłanych ramkach było wiadomo jaki jest status czego. Proponuję żebyś dodał do ack takie pole w definicjach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.