[pull] master from DefinitelyTyped:master#314
Merged
pull[bot] merged 27 commits intoSimenB:masterfrom Dec 26, 2018
Merged
Conversation
DetoxJestAdapter needs to overlap jasmine.CustomReporter since the latter is a weak interface; otherwise the code that is needed to run Detox with Jest will throw errors when compiled.
As you can see here: https://github.com/indutny/elliptic/blob/master/lib/elliptic/ec/signature.js#L17-L18 options.r and options.s is fed as input to BN and thus should be typed as BNInput. Without this, I believe it is impossible to import a signature with these typings, because the number type can't hold numbers large enough for r and s.
Expand result type to support promise and non-promise result.
[list-git-remotes] Add types
[npm-paths] Add types
[global-paths] Add types
[cwd] Add types
[remote-origin-url] Add types
[git-user-name] Add types
[is-git-url] Add types
[parse-git-config] Update types to v3
[detox] Fix typo for location of detox test runner adapters
elliptic: Update SignatureOptions to use BNInput for r and s
[generic-pool] Fix return type of callback in "use" function
h2o2: update to hapi@17 compatible h2o2@8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]