bugfix - 230/Stop player should not be freed the resources #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Feb 20, 2024
Collaborator
ujas-m-simformsolutions
left a comment
ujas-m-simformsolutions
left a comment
There was a problem hiding this comment.
Also, do remove unnecessary file changes.
android/src/main/kotlin/com/simform/audio_waveforms/AudioWaveformsPlugin.kt
Outdated
Show resolved
Hide resolved
ujas-m-simformsolutions
approved these changes
Feb 29, 2024
Collaborator
ujas-m-simformsolutions
left a comment
ujas-m-simformsolutions
left a comment
There was a problem hiding this comment.
Just remove necessary IOS file changes and we can merge this
himanshuGandhiSimform
deleted the
fix/230/stop_player_should_not_freed_the_resournce
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement - implement audio player freed resource functionality.