fix: 🐛 Cannot catch error of preparePlayer (#301) #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Nov 29, 2024
| player?.prepare() | ||
| playerListener = object : Player.Listener { | ||
|
|
||
| override fun onPlayerError(error: com.google.android.exoplayer2.PlaybackException) { |
Collaborator
There was a problem hiding this comment.
I think we can import this and just use type here
|
|
||
| override fun onPlayerError(error: com.google.android.exoplayer2.PlaybackException) { | ||
| super.onPlayerError(error) | ||
| result.error(Constants.LOG_TAG, error.message, "Exo-Player Error") |
Collaborator
There was a problem hiding this comment.
Exo player error doesn't look informative.
example/pubspec.yaml
Outdated
| - assets/audios/audio3.mp3 | ||
| - assets/audios/audio4.mp3 | ||
|
|
||
| - assets/audios/audio5.mp3 |
Collaborator
There was a problem hiding this comment.
Did you forget to remove it?
jay-simformsolutions
force-pushed
the
fix/301/catchError_not_catch_error
branch
3 times, most recently
from
50f0427 to
1bc547f
Compare
jay-simformsolutions
force-pushed
the
fix/301/catchError_not_catch_error
branch
from
1bc547f to
d08dc3c
Compare
ujas-m-simformsolutions
approved these changes
Dec 2, 2024
ujas-m-simformsolutions
deleted the
fix/301/catchError_not_catch_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #301