feat: ✨Add waveform extraction controller #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshu-simformsolutions
force-pushed
the
feature/add_waveform_extraction_class
branch
from
407dfb8 to
2e69aea
Compare
ujas-m-simformsolutions
requested changes
Mar 24, 2025
lib/src/audio_file_waveforms.dart
Outdated
| } else { | ||
| if (playerController.waveformData.isNotEmpty) { | ||
| _addWaveformData(playerController.waveformData); | ||
| if (playerController.waveformExtraction.waveformData.isNotEmpty) { |
Collaborator
There was a problem hiding this comment.
take waveformExtraction into separate variable
| @@ -0,0 +1,56 @@ | |||
| part of 'player_controller.dart'; | |||
|
|
|||
| class WaveformExtractionController { | |||
Collaborator
There was a problem hiding this comment.
Please docs above this and also above constructor.
|
|
||
| final List<double> _waveformData = []; | ||
|
|
||
| List<double> get waveformData => _waveformData.toList(); |
Collaborator
There was a problem hiding this comment.
here as well
priyanshu-simformsolutions
force-pushed
the
feature/add_seprate_stop_call_for_waveform_extraction
branch
from
7605f27 to
11044ca
Compare
priyanshu-simformsolutions
force-pushed
the
feature/add_waveform_extraction_class
branch
from
2e69aea to
92c9821
Compare
priyanshu-simformsolutions
force-pushed
the
feature/add_seprate_stop_call_for_waveform_extraction
branch
from
11044ca to
6367e36
Compare
priyanshu-simformsolutions
force-pushed
the
feature/add_waveform_extraction_class
branch
from
92c9821 to
70f5191
Compare
Base automatically changed from
feature/add_seprate_stop_call_for_waveform_extraction
to
main
March 25, 2025 06:51
priyanshu-simformsolutions
force-pushed
the
feature/add_waveform_extraction_class
branch
2 times, most recently
from
fff12e1 to
171339b
Compare
| /// An unique key string associated with [this] player only | ||
| final playerKey = shortHash(UniqueKey()); | ||
|
|
||
| late final waveformExtraction = WaveformExtractionController._(playerKey); |
Collaborator
There was a problem hiding this comment.
add smaller docs comments here as well
|
|
||
| /// WaveformExtractionController is used for | ||
| /// extraction of waveform data as List<double>, | ||
| /// which can be used to show [AudioWaveforms] |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// which can be used to show [AudioWaveforms] | |
| /// which can be used to show **Audio Waveforms** |
Contributor
Author
There was a problem hiding this comment.
In dart documentation comment if we add class name as [AudioWaveforms], then user can easily navigate to that class, so instead using [AudioFileWaveforms] here, which is a proper widget class ref.
priyanshu-simformsolutions
force-pushed
the
feature/add_waveform_extraction_class
branch
from
171339b to
ec51d36
Compare
priyanshu-simformsolutions
force-pushed
the
feature/add_waveform_extraction_class
branch
from
ec51d36 to
5c92ffc
Compare
ujas-m-simformsolutions
approved these changes
Mar 25, 2025
ujas-m-simformsolutions
deleted the
feature/add_waveform_extraction_class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WaveformExtractionController and migrate below methods and getters into it.